Merge pull request #8 from sakama/add-validation

Add validation for auto_create_table option

Author: sakama

src/main/java/org/embulk/output/dynamodb/DynamodbOutputPlugin.java

@@ -300,7 +300,8 @@ public void jsonColumn(Column column)
                                         list.add(getRawFromValue(v));
                                     }
                                     item.withList(column.getName(), list);
-                                } else {
+                                }
+                                else {
                                     item.withJSON(column.getName(), jsonValue.toJson());
                                 }
                             }
@@ -314,26 +315,32 @@ private void addNullValue(String name)
                         private Object getRawFromValue(Value value)
                         {
                             if (value.isBooleanValue()) {
-                                return ((BooleanValue)value).getBoolean();
-                            } else if (value.isStringValue()) {
+                                return ((BooleanValue) value).getBoolean();
+                            }
+                            else if (value.isStringValue()) {
                                 return value.toString();
-                            } else if (value.isIntegerValue()) {
-                                return ((IntegerValue)value).asLong();
-                            } else if (value.isFloatValue()) {
-                                return ((FloatValue)value).toDouble();
-                            } else if (value.isArrayValue()) {
+                            }
+                            else if (value.isIntegerValue()) {
+                                return ((IntegerValue) value).asLong();
+                            }
+                            else if (value.isFloatValue()) {
+                                return ((FloatValue) value).toDouble();
+                            }
+                            else if (value.isArrayValue()) {
                                 List<Object> list = new ArrayList<>();
                                 for (Value v : value.asArrayValue()) {
                                     list.add(getRawFromValue(v));
                                 }
                                 return list;
-                            } else if (value.isMapValue()) {
+                            }
+                            else if (value.isMapValue()) {
                                 Map<String, Object> map = new LinkedHashMap<>();
                                 for (Map.Entry<Value, Value> entry : value.asMapValue().entrySet()) {
                                     map.put(entry.getKey().toString(), getRawFromValue(entry.getValue()));
                                 }
                                 return map;
-                            } else if (value.isNilValue()) {
+                            }
+                            else if (value.isNilValue()) {
                                 return null;
                             }
                             throw new DataException("Record has invalid json column value");

src/main/java/org/embulk/output/dynamodb/DynamodbUtils.java

@@ -111,6 +111,9 @@ protected void configCheck(DynamodbOutputPlugin.PluginTask task)
             if (!task.getPrimaryKey().isPresent() || !task.getPrimaryKeyType().isPresent()) {
                 throw new ConfigException("If auto_create_table is true, both primary_key and primary_key_type is necessary");
             }
+            if (!task.getReadCapacityUnits().isPresent() || !task.getWriteCapacityUnits().isPresent()) {
+                throw new ConfigException("If auto_create_table is true, 'read_capacity_units' and 'write_capacity_units' is required.");
+            }
         }
     }