Skip to content

Commit 4e3f7c9

Browse files
committed
Address reviewer comments
1 parent 787b086 commit 4e3f7c9

File tree

3 files changed

+5
-8
lines changed

3 files changed

+5
-8
lines changed

pyproject.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -243,7 +243,6 @@ target-version = "py311"
243243
[tool.ruff.lint]
244244
ignore = [
245245
"E501", # Line too long - hard to avoid in doctests, and better handled by black.
246-
"UP045", # non-pep604-annotation-optional - Whether `Optional[T]` or `T | None` is better is subjective.
247246
]
248247
select = [
249248
"E", # pycodestyle errors - https://docs.astral.sh/ruff/rules/#error-e

src/sage/rings/function_field/element_rational.pyi

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
from typing import Any
22
from sage.rings.function_field.element import FunctionFieldElement
3-
import builtins
43

54
class FunctionFieldElement_rational(FunctionFieldElement):
65
def __init__(self, parent: Any, x: Any, reduce: bool = True) -> None:
@@ -12,7 +11,7 @@ class FunctionFieldElement_rational(FunctionFieldElement):
1211
def element(self) -> Any:
1312
...
1413

15-
def list(self) -> builtins.list:
14+
def list(self) -> list:
1615
...
1716

1817
def _repr_(self) -> str:

src/sage/rings/laurent_series_ring_element.pyi

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
from typing import Any, Optional, Union
2-
import builtins
32

43
class LaurentSeriesRingElement:
54
def __init__(self, parent: Any, f: Any, n: int = 0) -> None:
@@ -23,7 +22,7 @@ class LaurentSeriesRingElement:
2322
def __bool__(self) -> bool:
2423
...
2524

26-
def _im_gens_(self, codomain: Any, im_gens: builtins.list[Any], base_map: Optional[Any] = None) -> 'LaurentSeriesRingElement':
25+
def _im_gens_(self, codomain: Any, im_gens: list[Any], base_map: Optional[Any] = None) -> 'LaurentSeriesRingElement':
2726
...
2827

2928
def _normalize(self) -> None:
@@ -49,16 +48,16 @@ class LaurentSeriesRingElement:
4948
def __iter__(self) -> Any:
5049
...
5150

52-
def list(self) -> builtins.list[Any]:
51+
def list(self) -> list[Any]:
5352
...
5453

55-
def coefficients(self) -> builtins.list[Any]:
54+
def coefficients(self) -> list[Any]:
5655
...
5756

5857
def residue(self) -> Any:
5958
...
6059

61-
def exponents(self) -> builtins.list[int]:
60+
def exponents(self) -> list[int]:
6261
...
6362

6463
def laurent_polynomial(self) -> Any:

0 commit comments

Comments
 (0)