rename feature gate to extern_item_impls

jdonszelmann · jdonszelmann · commit cbd6653abc6b · 2025-12-01T17:18:49.000+01:00
diff --git a/compiler/rustc_error_codes/src/error_codes/E0806.md b/compiler/rustc_error_codes/src/error_codes/E0806.md
@@ -3,7 +3,7 @@ An externally implementable item is not compatible with its declaration.
 Erroneous code example:
 
 ```rust,edition2021,compile_fail,E0806
-#![feature(eii)]
+#![feature(extern_item_impls)]
 
 #[eii(foo)]
 fn x();
@@ -25,7 +25,7 @@ that of the declaration of `foo`.
 So, to fix this, `y`'s signature must be changed to match that of `x`:
 
 ```rust,edition2021
-#![feature(eii)]
+#![feature(extern_item_impls)]
 
 #[eii(foo)]
 fn x();
diff --git a/compiler/rustc_feature/src/unstable.rs b/compiler/rustc_feature/src/unstable.rs
@@ -493,8 +493,6 @@ declare_features! (
     (unstable, doc_masked, "1.21.0", Some(44027)),
     /// Allows features to allow target_feature to better interact with traits.
     (incomplete, effective_target_features, "1.91.0", Some(143352)),
-    /// Externally implementatble items
-    (unstable, extern_item_impls, "CURRENT_RUSTC_VERSION", Some(125418)),
     /// Allows the .use postfix syntax `x.use` and use closures `use |x| { ... }`
     (incomplete, ergonomic_clones, "1.87.0", Some(132290)),
     /// Allows exhaustive pattern matching on types that contain uninhabited types.
@@ -505,6 +503,8 @@ declare_features! (
     (incomplete, explicit_tail_calls, "1.72.0", Some(112788)),
     /// Allows using `#[export_stable]` which indicates that an item is exportable.
     (incomplete, export_stable, "1.88.0", Some(139939)),
+    /// Externally implementatble items
+    (unstable, extern_item_impls, "CURRENT_RUSTC_VERSION", Some(125418)),
     /// Allows defining `extern type`s.
     (unstable, extern_types, "1.23.0", Some(43467)),
     /// Allow using 128-bit (quad precision) floating point numbers.
diff --git a/compiler/rustc_span/src/symbol.rs b/compiler/rustc_span/src/symbol.rs
@@ -931,7 +931,6 @@ symbols! {
         eii_extern_target,
         eii_impl,
         eii_internals,
-        extern_item_impls,
         eii_shared_macro,
         emit,
         emit_enum,
@@ -992,6 +991,7 @@ symbols! {
         extern_crate_item_prelude,
         extern_crate_self,
         extern_in_paths,
+        extern_item_impls,
         extern_prelude,
         extern_system_varargs,
         extern_types,
diff --git a/library/core/src/macros/mod.rs b/library/core/src/macros/mod.rs
@@ -1893,7 +1893,7 @@ pub(crate) mod builtin {
 
     /// Externally Implementable Item: Defines an attribute macro that can override the item
     /// this is applied to.
-    #[unstable(feature = "eii", issue = "125418")]
+    #[unstable(feature = "extern_item_impls", issue = "125418")]
     #[rustc_builtin_macro]
     #[allow_internal_unstable(eii_internals, decl_macro, rustc_attrs)]
     pub macro eii($item:item) {
@@ -1902,7 +1902,7 @@ pub(crate) mod builtin {
 
     /// Unsafely Externally Implementable Item: Defines an unsafe attribute macro that can override
     /// the item this is applied to.
-    #[unstable(feature = "eii", issue = "125418")]
+    #[unstable(feature = "extern_item_impls", issue = "125418")]
     #[rustc_builtin_macro]
     #[allow_internal_unstable(eii_internals, decl_macro, rustc_attrs)]
     pub macro unsafe_eii($item:item) {
diff --git a/library/core/src/prelude/v1.rs b/library/core/src/prelude/v1.rs
@@ -125,7 +125,7 @@ pub use crate::macros::builtin::define_opaque;
 )]
 pub use crate::macros::builtin::From;
 
-#[unstable(feature = "eii", issue = "125418")]
+#[unstable(feature = "extern_item_impls", issue = "125418")]
 pub use crate::macros::builtin::{eii, unsafe_eii};
 
 #[unstable(feature = "eii_internals", issue = "none")]
diff --git a/library/std/src/prelude/v1.rs b/library/std/src/prelude/v1.rs
@@ -110,7 +110,7 @@ pub use core::prelude::v1::deref;
 )]
 pub use core::prelude::v1::define_opaque;
 
-#[unstable(feature = "eii", issue = "125418")]
+#[unstable(feature = "extern_item_impls", issue = "125418")]
 pub use core::prelude::v1::{eii, unsafe_eii};
 
 #[unstable(feature = "eii_internals", issue = "none")]
diff --git a/tests/ui/eii/auxiliary/codegen1.rs b/tests/ui/eii/auxiliary/codegen1.rs
@@ -1,6 +1,6 @@
 //@ no-prefer-dynamic
 #![crate_type = "rlib"]
-#![feature(eii)]
+#![feature(extern_item_impls)]
 
 #[eii(eii1)]
 fn decl1(x: u64);
diff --git a/tests/ui/eii/auxiliary/codegen2.rs b/tests/ui/eii/auxiliary/codegen2.rs
@@ -1,6 +1,6 @@
 //@ no-prefer-dynamic
 #![crate_type = "rlib"]
-#![feature(eii)]
+#![feature(extern_item_impls)]
 
 #[eii(eii1)]
 pub fn decl1(x: u64);
diff --git a/tests/ui/eii/auxiliary/codegen3.rs b/tests/ui/eii/auxiliary/codegen3.rs
@@ -1,6 +1,6 @@
 //@ no-prefer-dynamic
 #![crate_type = "rlib"]
-#![feature(eii)]
+#![feature(extern_item_impls)]
 
 // does have an impl but can't be called
 #[eii(eii1)]
diff --git a/tests/ui/eii/auxiliary/cross_crate_eii_declaration.rs b/tests/ui/eii/auxiliary/cross_crate_eii_declaration.rs
@@ -1,6 +1,6 @@
 //@ no-prefer-dynamic
 #![crate_type = "rlib"]
-#![feature(eii)]
+#![feature(extern_item_impls)]
 #![feature(decl_macro)]
 #![feature(rustc_attrs)]
 #![feature(eii_internals)]
diff --git a/tests/ui/eii/codegen_cross_crate.rs b/tests/ui/eii/codegen_cross_crate.rs
@@ -4,7 +4,7 @@
 //@ compile-flags: -O
 //@ ignore-backends: gcc
 // Tests whether calling EIIs works with the declaration in another crate.
-#![feature(eii)]
+#![feature(extern_item_impls)]
 
 extern crate codegen2 as codegen;
 
diff --git a/tests/ui/eii/codegen_single_crate.rs b/tests/ui/eii/codegen_single_crate.rs
@@ -2,7 +2,7 @@
 //@ check-run-results
 //@ ignore-backends: gcc
 // Tests whether calling EIIs works with the declaration in the same crate.
-#![feature(eii)]
+#![feature(extern_item_impls)]
 
 #[eii]
 fn hello(x: u64);
diff --git a/tests/ui/eii/cross_crate.rs b/tests/ui/eii/cross_crate.rs
@@ -2,7 +2,7 @@
 //@ check-pass
 //@ aux-build: cross_crate_eii_declaration.rs
 // Tests whether calling EIIs works with the declaration in another crate.
-#![feature(eii)]
+#![feature(extern_item_impls)]
 #![feature(decl_macro)]
 #![feature(rustc_attrs)]
 #![feature(eii_internals)]
diff --git a/tests/ui/eii/cross_crate_wrong_ty.rs b/tests/ui/eii/cross_crate_wrong_ty.rs
@@ -1,7 +1,7 @@
 //@ compile-flags: --crate-type rlib
 //@ aux-build: cross_crate_eii_declaration.rs
 // Tests whether the type checking still works properly when the declaration is in another crate.
-#![feature(eii)]
+#![feature(extern_item_impls)]
 #![feature(decl_macro)]
 #![feature(rustc_attrs)]
 #![feature(eii_internals)]
diff --git a/tests/ui/eii/default/auxiliary/decl_with_default.rs b/tests/ui/eii/default/auxiliary/decl_with_default.rs
@@ -1,6 +1,6 @@
 //@ no-prefer-dynamic
 #![crate_type = "rlib"]
-#![feature(eii)]
+#![feature(extern_item_impls)]
 
 #[eii(eii1)]
 pub fn decl1(x: u64) {
diff --git a/tests/ui/eii/default/auxiliary/impl1.rs b/tests/ui/eii/default/auxiliary/impl1.rs
@@ -1,7 +1,7 @@
 //@ no-prefer-dynamic
 //@ aux-build: decl_with_default.rs
 #![crate_type = "rlib"]
-#![feature(eii)]
+#![feature(extern_item_impls)]
 
 extern crate decl_with_default as decl;
 
diff --git a/tests/ui/eii/default/call_default.rs b/tests/ui/eii/default/call_default.rs
@@ -5,7 +5,7 @@
 //@ ignore-backends: gcc
 // Tests EIIs with default implementations.
 // When there's no explicit declaration, the default should be called from the declaring crate.
-#![feature(eii)]
+#![feature(extern_item_impls)]
 
 extern crate decl_with_default;
 
diff --git a/tests/ui/eii/default/call_impl.rs b/tests/ui/eii/default/call_impl.rs
@@ -7,7 +7,7 @@
 // Tests EIIs with default implementations.
 // When an explicit implementation is given in one dependency, and the declaration is in another,
 // the explicit implementation is preferred.
-#![feature(eii)]
+#![feature(extern_item_impls)]
 
 extern crate decl_with_default;
 extern crate impl1;
diff --git a/tests/ui/eii/default/local_crate.rs b/tests/ui/eii/default/local_crate.rs
@@ -3,7 +3,7 @@
 //@ ignore-backends: gcc
 // Tests EIIs with default implementations.
 // In the same crate, when there's no explicit declaration, the default should be called.
-#![feature(eii)]
+#![feature(extern_item_impls)]
 
 #[eii(eii1)]
 pub fn decl1(x: u64) {
diff --git a/tests/ui/eii/default/local_crate_explicit.rs b/tests/ui/eii/default/local_crate_explicit.rs
@@ -3,7 +3,7 @@
 //@ ignore-backends: gcc
 // Tests EIIs with default implementations.
 // In the same crate, the explicit implementation should get priority.
-#![feature(eii)]
+#![feature(extern_item_impls)]
 
 #[eii(eii1)]
 pub fn decl1(x: u64) {
diff --git a/tests/ui/eii/duplicate/auxiliary/decl.rs b/tests/ui/eii/duplicate/auxiliary/decl.rs
@@ -1,6 +1,6 @@
 //@ no-prefer-dynamic
 #![crate_type = "rlib"]
-#![feature(eii)]
+#![feature(extern_item_impls)]
 
 #[eii(eii1)]
 fn decl1(x: u64);
diff --git a/tests/ui/eii/duplicate/auxiliary/impl1.rs b/tests/ui/eii/duplicate/auxiliary/impl1.rs
@@ -1,7 +1,7 @@
 //@ no-prefer-dynamic
 //@ aux-build: decl.rs
 #![crate_type = "rlib"]
-#![feature(eii)]
+#![feature(extern_item_impls)]
 
 extern crate decl;
 
diff --git a/tests/ui/eii/duplicate/auxiliary/impl2.rs b/tests/ui/eii/duplicate/auxiliary/impl2.rs
@@ -1,7 +1,7 @@
 //@ no-prefer-dynamic
 //@ aux-build: decl.rs
 #![crate_type = "rlib"]
-#![feature(eii)]
+#![feature(extern_item_impls)]
 
 extern crate decl;
 
diff --git a/tests/ui/eii/duplicate/auxiliary/impl3.rs b/tests/ui/eii/duplicate/auxiliary/impl3.rs
@@ -1,7 +1,7 @@
 //@ no-prefer-dynamic
 //@ aux-build: decl.rs
 #![crate_type = "rlib"]
-#![feature(eii)]
+#![feature(extern_item_impls)]
 
 extern crate decl;
 
diff --git a/tests/ui/eii/duplicate/auxiliary/impl4.rs b/tests/ui/eii/duplicate/auxiliary/impl4.rs
@@ -1,7 +1,7 @@
 //@ no-prefer-dynamic
 //@ aux-build: decl.rs
 #![crate_type = "rlib"]
-#![feature(eii)]
+#![feature(extern_item_impls)]
 
 extern crate decl;
 
diff --git a/tests/ui/eii/duplicate/duplicate1.rs b/tests/ui/eii/duplicate/duplicate1.rs
@@ -3,7 +3,7 @@
 //@ aux-build: impl2.rs
 //@ ignore-backends: gcc
 // tests that EIIs error properly, even if the conflicting implementations live in another crate.
-#![feature(eii)]
+#![feature(extern_item_impls)]
 
 // has a span but in the other crate
 //~? ERROR multiple implementations of `#[eii1]`
diff --git a/tests/ui/eii/duplicate/duplicate2.rs b/tests/ui/eii/duplicate/duplicate2.rs
@@ -4,7 +4,7 @@
 //@ aux-build: impl3.rs
 //@ ignore-backends: gcc
 // Tests the error message when there are multiple implementations of an EII in many crates.
-#![feature(eii)]
+#![feature(extern_item_impls)]
 
 // has a span but in the other crate
 //~? ERROR multiple implementations of `#[eii1]`
diff --git a/tests/ui/eii/duplicate/duplicate3.rs b/tests/ui/eii/duplicate/duplicate3.rs
@@ -5,7 +5,7 @@
 //@ aux-build: impl4.rs
 //@ ignore-backends: gcc
 // Tests the error message when there are multiple implementations of an EII in many crates.
-#![feature(eii)]
+#![feature(extern_item_impls)]
 
 // has a span but in the other crate
 //~? ERROR multiple implementations of `#[eii1]`
diff --git a/tests/ui/eii/errors.rs b/tests/ui/eii/errors.rs
@@ -1,6 +1,6 @@
 //@ compile-flags: --crate-type rlib
 // Tests all the kinds of errors when EII attributes are used with wrong syntax.
-#![feature(eii)]
+#![feature(extern_item_impls)]
 #![feature(decl_macro)]
 #![feature(rustc_attrs)]
 #![feature(eii_internals)]
diff --git a/tests/ui/eii/multiple_decls.rs b/tests/ui/eii/multiple_decls.rs
@@ -1,5 +1,5 @@
 // Tests whether only one EII attribute cane be applied to a signature.
-#![feature(eii)]
+#![feature(extern_item_impls)]
 
 #[eii(a)]
 #[eii(b)]
diff --git a/tests/ui/eii/multiple_impls.rs b/tests/ui/eii/multiple_impls.rs
@@ -2,7 +2,7 @@
 //@ check-run-results
 //@ ignore-backends: gcc
 // Tests whether one function could implement two EIIs.
-#![feature(eii)]
+#![feature(extern_item_impls)]
 
 #[eii]
 fn a(x: u64);
diff --git a/tests/ui/eii/privacy1.rs b/tests/ui/eii/privacy1.rs
@@ -3,7 +3,7 @@
 //@ aux-build: codegen1.rs
 //@ ignore-backends: gcc
 // Tests whether re-exports work.
-#![feature(eii)]
+#![feature(extern_item_impls)]
 
 extern crate codegen1 as codegen;
 
diff --git a/tests/ui/eii/privacy2.rs b/tests/ui/eii/privacy2.rs
@@ -1,6 +1,6 @@
 //@ aux-build:codegen3.rs
 // Tests whether name resulution respects privacy properly.
-#![feature(eii)]
+#![feature(extern_item_impls)]
 
 extern crate codegen3 as codegen;
 
diff --git a/tests/ui/eii/subtype_1.rs b/tests/ui/eii/subtype_1.rs
@@ -1,7 +1,7 @@
 //@ compile-flags: --crate-type rlib
 // Uses manual desugaring of EII internals:
 // Tests whether it's not ok when the lifetimes are different between the decl and impl.
-#![feature(eii)]
+#![feature(extern_item_impls)]
 #![feature(decl_macro)]
 #![feature(rustc_attrs)]
 #![feature(eii_internals)]
diff --git a/tests/ui/eii/subtype_2.rs b/tests/ui/eii/subtype_2.rs
@@ -1,7 +1,7 @@
 //@ compile-flags: --crate-type rlib
 // Uses manual desugaring of EII internals:
 // Tests whether it's not ok when the implementation is less general.
-#![feature(eii)]
+#![feature(extern_item_impls)]
 #![feature(decl_macro)]
 #![feature(rustc_attrs)]
 #![feature(eii_internals)]
diff --git a/tests/ui/eii/subtype_3.rs b/tests/ui/eii/subtype_3.rs
@@ -2,7 +2,7 @@
 //@ check-pass
 // Uses manual desugaring of EII internals:
 // Tests whether it's ok when the implementation is more general.
-#![feature(eii)]
+#![feature(extern_item_impls)]
 #![feature(decl_macro)]
 #![feature(rustc_attrs)]
 #![feature(eii_internals)]
diff --git a/tests/ui/eii/subtype_4.rs b/tests/ui/eii/subtype_4.rs
@@ -2,7 +2,7 @@
 //@ check-pass
 // Uses manual desugaring of EII internals:
 // Tests whether it's ok when giving the right types.
-#![feature(eii)]
+#![feature(extern_item_impls)]
 #![feature(decl_macro)]
 #![feature(rustc_attrs)]
 #![feature(eii_internals)]
diff --git a/tests/ui/eii/unsafe_impl_err.rs b/tests/ui/eii/unsafe_impl_err.rs
@@ -1,6 +1,6 @@
 //@ compile-flags: --crate-type rlib
 // Tests whether it's an error to implement an unsafe EII safely.
-#![feature(eii)]
+#![feature(extern_item_impls)]
 #![feature(decl_macro)]
 #![feature(rustc_attrs)]
 #![feature(eii_internals)]
diff --git a/tests/ui/eii/unsafe_impl_ok.rs b/tests/ui/eii/unsafe_impl_ok.rs
@@ -2,7 +2,7 @@
 //@ check-pass
 // Uses manual desugaring of EII internals:
 // Tests whether it's okay to implement an unsafe EII with an unsafe implementation.
-#![feature(eii)]
+#![feature(extern_item_impls)]
 #![feature(decl_macro)]
 #![feature(rustc_attrs)]
 #![feature(eii_internals)]
diff --git a/tests/ui/eii/wrong_ret_ty.rs b/tests/ui/eii/wrong_ret_ty.rs
@@ -1,6 +1,6 @@
 //@ compile-flags: --crate-type rlib
 // Uses manual desugaring of EII internals: tests whether the return type matches.
-#![feature(eii)]
+#![feature(extern_item_impls)]
 #![feature(decl_macro)]
 #![feature(rustc_attrs)]
 #![feature(eii_internals)]
diff --git a/tests/ui/eii/wrong_target.rs b/tests/ui/eii/wrong_target.rs
@@ -1,4 +1,4 @@
-#![feature(eii)]
+#![feature(extern_item_impls)]
 // Check whether the EII attributes do target checking properly.
 
 #[eii]
diff --git a/tests/ui/eii/wrong_ty.rs b/tests/ui/eii/wrong_ty.rs
@@ -1,6 +1,6 @@
 //@ compile-flags: --crate-type rlib
 // Uses manual desugaring of EII internals: tests whether the types of parameters match.
-#![feature(eii)]
+#![feature(extern_item_impls)]
 #![feature(decl_macro)]
 #![feature(rustc_attrs)]
 #![feature(eii_internals)]
diff --git a/tests/ui/eii/wrong_ty_2.rs b/tests/ui/eii/wrong_ty_2.rs
diff --git a/tests/ui/error-codes/E0806.rs b/tests/ui/error-codes/E0806.rs
diff --git a/tests/ui/feature-gates/feature-gate-extern-item-impls.rs b/tests/ui/feature-gates/feature-gate-extern-item-impls.rs
diff --git a/tests/ui/feature-gates/feature-gate-extern-item-impls.stderr b/tests/ui/feature-gates/feature-gate-extern-item-impls.stderr
