Skip to content

Commit edba308

Browse files
authored
fix(timings): unlocked -> unblocked (#16337)
### What does this PR try to resolve? In 6562d03, we renamed all `unlocked_*` to `unblocked_*` in all Rust files but overlooked JavaScript files. This got us: ``` Uncaught TypeError: can't access property Symbol.iterator, unit.unlocked_units is undefined ``` ### How to test and review this PR? `cargo build --timings` and the canvas displays correctly.
2 parents e0dd406 + c28892d commit edba308

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

src/cargo/core/compiler/timings/timings.js

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -78,11 +78,11 @@ const CPU_COLOR = getCssColor('--canvas-cpu');
7878

7979
for (let n=0; n<UNIT_DATA.length; n++) {
8080
let unit = UNIT_DATA[n];
81-
for (let unlocked of unit.unlocked_units) {
82-
REVERSE_UNIT_DEPS[unlocked] = n;
81+
for (let unblocked of unit.unblocked_units) {
82+
REVERSE_UNIT_DEPS[unblocked] = n;
8383
}
84-
for (let unlocked of unit.unlocked_rmeta_units) {
85-
REVERSE_UNIT_RMETA_DEPS[unlocked] = n;
84+
for (let unblocked of unit.unblocked_rmeta_units) {
85+
REVERSE_UNIT_RMETA_DEPS[unblocked] = n;
8686
}
8787
}
8888

@@ -323,12 +323,12 @@ function draw_dep_lines(ctx, unit_idx, highlighted) {
323323
const unit = UNIT_DATA[unit_idx];
324324
const {x, y, sections} = UNIT_COORDS[unit_idx];
325325
ctx.save();
326-
for (const unlocked of unit.unlocked_units) {
327-
draw_one_dep_line(ctx, x, y, unlocked, highlighted);
326+
for (const unblocked of unit.unblocked_units) {
327+
draw_one_dep_line(ctx, x, y, unblocked, highlighted);
328328
}
329-
for (const unlocked of unit.unlocked_rmeta_units) {
329+
for (const unblocked of unit.unblocked_rmeta_units) {
330330
const codegen_x = get_codegen_section_x(sections);
331-
draw_one_dep_line(ctx, codegen_x, y, unlocked, highlighted);
331+
draw_one_dep_line(ctx, codegen_x, y, unblocked, highlighted);
332332
}
333333
ctx.restore();
334334
}

0 commit comments

Comments
 (0)