feat: impl PeekingNext for std::collections::* #1073
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1073 +/- ##
==========================================
- Coverage 94.38% 93.75% -0.64%
==========================================
Files 48 50 +2
Lines 6665 6326 -339
==========================================
- Hits 6291 5931 -360
- Misses 374 395 +21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hashmap is only available under |
src/peeking_take_while.rs
Outdated
| peeking_next_by_clone! { ['a, T] alloc::collections::linked_list::Iter<'a, T> } | ||
| #[cfg(feature = "use_alloc")] | ||
| peeking_next_by_clone! { ['a, T] alloc::collections::vec_deque::Iter<'a, T> } | ||
| const _: () = { |
There was a problem hiding this comment.
Please replace then const _ with repeated gates.
If we start adopting this pattern, we should do it consistently and not arbitrarily only here.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
phimuemue
left a comment
phimuemue
left a comment
There was a problem hiding this comment.
Can you fix CI and squash the commits?
phimuemue
force-pushed
the
aatifsyed/peeking-next-btree
branch
from
8c7e761 to
556ed1a
Compare
|
Hi @aatifsyed, I'm unsure. If you want to fix these, I'd happily merge it. |
|
The semver checks failure seems spurious. |
aatifsyed
force-pushed
the
aatifsyed/peeking-next-btree
branch
from
df58323 to
a03c199
Compare
|
squashed :) |
3f99dc6
2 participants
No description provided.