Skip to content

update examples #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 29, 2025
Merged

update examples #109

merged 1 commit into from
Nov 29, 2025
+141 −47

Conversation

@robamu
Copy link
Contributor

@robamu robamu commented Nov 20, 2025 •
edited
Loading

  • Introduce defmt which is very commonly used on embedded systems. It is used to print the allocated structures.
  • New QEMU runner to support defmt.
  • Switch to more commonly used thumbv7em-none-eabihf target for the QEMU runner.

@robamu robamu requested a review from a team as a code owner November 20, 2025 12:20
@robamu robamu marked this pull request as draft November 20, 2025 12:22
@robamu robamu marked this pull request as ready for review November 20, 2025 12:45
@robamu robamu mentioned this pull request Nov 20, 2025
Closed
@robamu
Copy link
Contributor Author

robamu commented Nov 20, 2025 •
edited
Loading

With #110 , I think the additional example is not required anymore. The heap memory blocks will be placed into .bss anyway.

@robamu robamu mentioned this pull request Nov 20, 2025
Draft
@robamu
Copy link
Contributor Author

robamu commented Nov 21, 2025

The shell script could be avoided by using knurling-rs/defmt#1012 if that is released...

zeenix
zeenix reviewed Nov 27, 2025
View reviewed changes
zeenix
zeenix requested changes Nov 27, 2025
View reviewed changes
Copy link
Contributor

@zeenix zeenix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the nitpick. The CI isn't going forward though. 🤔 Can you please rebase the branch and force push?

@robamu
Copy link
Contributor Author

robamu commented Nov 27, 2025

I am not sure what is going on with the CI. It is related to steps which were removed. Maybe this can be safely ignored?
I can try rebasing though.

@robamu
update examples
de38e9e 
- Introduce `defmt` which is very commonly used on embedded systems. It
  is used to print the allocated structures.
- New QEMU runner to support defmt.
- Introduce new example which uses a global heap initialized on BSS
  memory.
- Switch to more commonly used thumbv7em-none-eabihf target for the QEMU
  runner. thumbv6m-none-eabi is still supported as well.
@robamu
Copy link
Contributor Author

robamu commented Nov 27, 2025

I rebased and squashed. If you still prefer to have the quick switch option inside the config file removed, I can also do that.

@zeenix zeenix enabled auto-merge November 29, 2025 13:31
@zeenix zeenix disabled auto-merge November 29, 2025 15:10
@zeenix zeenix added this pull request to the merge queue Nov 29, 2025
Merged via the queue into rust-embedded:master with commit f39bfba Nov 29, 2025
8 checks passed
@zeenix
Copy link
Contributor

zeenix commented Nov 29, 2025

For the record, I had to change the settings to require the removed CI jobs to get this merged. I'll change it back again after this is merged but with the new names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zeenix zeenix zeenix approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@robamu @zeenix