Merge #284: Address all TODO in v20

aa91a26 Check validateaddress and remove TODO (Jamil Lambert, PhD)
3f8efb9 Check signmessagewithprivkey and remove TODO (Jamil Lambert, PhD)
5804290 Check createmultisig and remove TODO (Jamil Lambert, PhD)
da6fc87 Add generatetodescriptor type, model and test (Jamil Lambert, PhD)

Pull request description:

  Go through all the `TODO` in v20 types. NB. v17 to v19 are all done already.

  Add the new RPC `generatetodescriptor`.

  Other 3 RPCs require no further action, remove the `TODO` with the reason stated in the commit log.

ACKs for top commit:
  tcharding:
    ACK aa91a26

Tree-SHA512: 121a855cc5c285c36b5ffd4ef31b5b977ab20778205c51992116ff1e127c88ec3e2b3eafd19bb810e22da179a87038ac5e1023e8f489855134c4876743b9e2e7

Author: tcharding

client/src/client_sync/v20/generating.rs

@@ -0,0 +1,26 @@
+// SPDX-License-Identifier: CC0-1.0
+
+//! Macros for implementing JSON-RPC methods on a client.
+//!
+//! Specifically this is methods found under the `== Generating ==` section of the
+//! API docs of Bitcoin Core `v0.20`.
+//!
+//! All macros require `Client` to be in scope.
+//!
+//! See or use the `define_jsonrpc_minreq_client!` macro to define a `Client`.
+
+/// Implements Bitcoin Core JSON-RPC API method `generatetodescriptor`
+#[macro_export]
+macro_rules! impl_client_v20__generate_to_descriptor {
+    () => {
+        impl Client {
+            pub fn generate_to_descriptor(
+                &self,
+                nblocks: usize,
+                descriptor: &str,
+            ) -> Result<GenerateToDescriptor> {
+                self.call("generatetodescriptor", &[nblocks.into(), descriptor.into()])
+            }
+        }
+    };
+}

client/src/client_sync/v20/mod.rs

@@ -4,6 +4,8 @@
 //!
 //! We ignore option arguments unless they effect the shape of the returned JSON data.
 
+pub mod generating;
+
 use std::collections::BTreeMap;
 use std::path::Path;
 
@@ -60,6 +62,7 @@ crate::impl_client_v17__uptime!();
 
 // == Generating ==
 crate::impl_client_v17__generate_to_address!();
+crate::impl_client_v20__generate_to_descriptor!();
 crate::impl_client_v17__invalidate_block!();
 
 // == Mining ==

client/src/client_sync/v21/mod.rs

@@ -62,6 +62,7 @@ crate::impl_client_v17__uptime!();
 
 // == Generating ==
 crate::impl_client_v17__generate_to_address!();
+crate::impl_client_v20__generate_to_descriptor!();
 crate::impl_client_v17__invalidate_block!();
 
 // == Mining ==

client/src/client_sync/v22/mod.rs

@@ -62,6 +62,7 @@ crate::impl_client_v17__uptime!();
 
 // == Generating ==
 crate::impl_client_v17__generate_to_address!();
+crate::impl_client_v20__generate_to_descriptor!();
 crate::impl_client_v17__invalidate_block!();
 
 // == Mining ==

client/src/client_sync/v23/mod.rs

@@ -64,6 +64,7 @@ crate::impl_client_v17__uptime!();
 
 // == Generating ==
 crate::impl_client_v17__generate_to_address!();
+crate::impl_client_v20__generate_to_descriptor!();
 crate::impl_client_v17__invalidate_block!();
 
 // == Mining ==

client/src/client_sync/v24/mod.rs

@@ -61,6 +61,7 @@ crate::impl_client_v17__uptime!();
 
 // == Generating ==
 crate::impl_client_v17__generate_to_address!();
+crate::impl_client_v20__generate_to_descriptor!();
 crate::impl_client_v17__invalidate_block!();
 
 // == Mining ==

client/src/client_sync/v25/mod.rs

@@ -61,6 +61,7 @@ crate::impl_client_v17__uptime!();
 
 // == Generating ==
 crate::impl_client_v17__generate_to_address!();
+crate::impl_client_v20__generate_to_descriptor!();
 crate::impl_client_v17__invalidate_block!();
 
 // == Mining ==

client/src/client_sync/v26/mod.rs

@@ -65,6 +65,7 @@ crate::impl_client_v17__uptime!();
 
 // == Generating ==
 crate::impl_client_v17__generate_to_address!();
+crate::impl_client_v20__generate_to_descriptor!();
 crate::impl_client_v17__invalidate_block!();
 
 // == Mining ==

client/src/client_sync/v27/mod.rs

@@ -61,6 +61,7 @@ crate::impl_client_v17__uptime!();
 
 // == Generating ==
 crate::impl_client_v17__generate_to_address!();
+crate::impl_client_v20__generate_to_descriptor!();
 crate::impl_client_v17__invalidate_block!();
 
 // == Mining ==

client/src/client_sync/v28/mod.rs

@@ -63,6 +63,7 @@ crate::impl_client_v17__uptime!();
 
 // == Generating ==
 crate::impl_client_v17__generate_to_address!();
+crate::impl_client_v20__generate_to_descriptor!();
 crate::impl_client_v17__invalidate_block!();
 
 // == Mining ==