Fix Style/FileRead Rubocop offences.

Author: hainesr

.rubocop_todo.yml

@@ -12,13 +12,3 @@ Layout/LeadingCommentSpace:
     - 'lib/zip/bzip2/errors.rb'
     - 'lib/zip/bzip2/ffi/libbz2.rb'
     - 'lib/zip/bzip2/libbz2.rb'
-
-# Offense count: 9
-# This cop supports safe autocorrection (--autocorrect).
-Style/FileRead:
-  Exclude:
-    - 'test/integration/zip_file_bzip2_support_test.rb'
-    - 'test/integration/zip_input_stream_bzip2_support_test.rb'
-    - 'test/models/zip/bzip2/decompress_test.rb'
-    - 'test/models/zip/bzip2/decompressor_test.rb'
-    - 'test/models/zip/bzip2/libbz2_test.rb'

test/integration/zip_file_bzip2_support_test.rb

@@ -17,10 +17,10 @@ def test_file_read
   private
 
   def file1_text
-    @file1_text ||= File.open(FILE1, 'r').read
+    @file1_text ||= File.read(FILE1)
   end
 
   def file2_text
-    @file2_text ||= File.open(FILE2, 'r').read
+    @file2_text ||= File.read(FILE2)
   end
 end

test/integration/zip_input_stream_bzip2_support_test.rb

@@ -34,10 +34,10 @@ def test_input_stream_encrypted_read
   private
 
   def file1_text
-    @file1_text ||= File.open(FILE1, 'r').read
+    @file1_text ||= File.read(FILE1)
   end
 
   def file2_text
-    @file2_text ||= File.open(FILE2, 'r').read
+    @file2_text ||= File.read(FILE2)
   end
 end

test/models/zip/bzip2/decompress_test.rb

@@ -43,10 +43,10 @@ def test_decompress_with_corrupted_input
   private
 
   def file_text
-    @file_text ||= File.open(FILE, &:read)
+    @file_text ||= File.read(FILE)
   end
 
   def compressed_data
-    @compressed_data ||= File.open(BZIP2_FILE, 'rb', &:read)
+    @compressed_data ||= File.binread(BZIP2_FILE)
   end
 end

test/models/zip/bzip2/decompressor_test.rb

@@ -39,6 +39,6 @@ def test_data_error
   private
 
   def test_text
-    @test_text ||= File.open(FILE1, &:read)
+    @test_text ||= File.read(FILE1)
   end
 end

test/models/zip/bzip2/libbz2_test.rb

@@ -74,10 +74,10 @@ def decompress(data)
   end
 
   def file_text
-    @file_text ||= File.open(FILE, &:read)
+    @file_text ||= File.read(FILE)
   end
 
   def compressed_data
-    @compressed_data ||= File.open(BZIP2_FILE, 'rb', &:read)
+    @compressed_data ||= File.binread(BZIP2_FILE)
   end
 end