Commit 28b43c1
committed
♻️ SASL DIGEST-MD5: inherit, props, move, document
* 🚚 Move to sasl directory and SASL namespace.
* 🗑️ Deprecate original constant name.
* ♻️ Inherit from Authenticator base class.
* ♻️ Refactor to the style used in the new ScramAuthenticator.
Yes, DIGEST-MD5 is deprecated! But that also means that it is lower
risk as a test-bed for refactoring a more complicated challenge/response
SASL mechanism, and for developing a reasonable SASL::Authenticator base
class. I improved it in several ways:
* 🔒 Use SecureRandom for cnonce (not Time.now + insecure PRNG!)
* ✨ Default qop=auth (as in RFC)
* ✨ User can configure realm, host, service_name, service.
* This allows a correct "digest-uri" for non-IMAP clients.
* ✨ Enforce requirements for sparam keys (required and no-multiples).
However... it's still deprecated, so maybe don't use unless you need to!1 parent c099f50 commit 28b43c1
File tree
6 files changed
+415
-120
lines changed- lib/net
- imap
- authenticators
- sasl
- test/net/imap/sasl
6 files changed
+415
-120
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
996 | 996 | | |
997 | 997 | | |
998 | 998 | | |
999 | | - | |
| 999 | + | |
1000 | 1000 | | |
1001 | 1001 | | |
1002 | 1002 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
73 | 73 | | |
74 | 74 | | |
75 | 75 | | |
76 | | - | |
| 76 | + | |
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
34 | | - | |
| 34 | + | |
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
| |||
0 commit comments