fixed feature create

Author: retailcoder

rubberduckvba.Server/Api/Features/FeaturesController.cs

@@ -159,7 +159,7 @@ public async Task<ActionResult<FeatureEditViewModel>> Create([FromQuery] Reposit
         return Ok(model);
     }
 
-    [HttpPost("create")]
+    [HttpPost("features/create")]
     [Authorize("github")]
     public async Task<ActionResult<FeatureEditViewModel>> Create([FromBody] FeatureEditViewModel model)
     {
@@ -168,7 +168,7 @@ public async Task<ActionResult<FeatureEditViewModel>> Create([FromBody] FeatureE
             return BadRequest("Model is invalid for this endpoint.");
         }
 
-        var existing = await db.ResolveFeature(model.RepositoryId, model.Name);
+        var existing = await db.GetFeatureId(model.RepositoryId, model.Name);
         if (existing != null)
         {
             return BadRequest($"Model [Name] must be unique; feature '{model.Name}' already exists.");
@@ -205,6 +205,8 @@ public async Task<ActionResult<FeatureEditViewModel>> Update([FromBody] FeatureE
         return new FeatureEditViewModel(result, features, RepositoryOptions);
     }
 
+
+
     [HttpPost("markdown/format")]
     public MarkdownContentViewModel FormatMarkdown([FromBody] MarkdownContentViewModel model)
     {

rubberduckvba.Server/Data/Repository.cs

@@ -9,6 +9,7 @@ namespace rubberduckvba.Server.Data;
 
 public interface IRepository<TEntity> where TEntity : Entity
 {
+    bool TryGetId(string name, out int id);
     int GetId(string name);
     TEntity GetById(int id);
     IEnumerable<TEntity> GetAll();
@@ -71,6 +72,20 @@ ParentFKColumnName is null || !parentId.HasValue
             ? GetAll()
             : Query(db => db.Query<TEntity>($"{SelectSql} WHERE a.[{ParentFKColumnName}]=@parentId", new { parentId }));
 
+    public virtual bool TryGetId(string name, out int id)
+    {
+        id = default;
+
+        var result = Get(db => db.QuerySingleOrDefault<int?>($"SELECT [Id] FROM [dbo].[{TableName}] WHERE [Name]=@name", new { name }));
+        if (result.HasValue)
+        {
+            id = result.Value;
+            return true;
+        }
+
+        return false;
+    }
+
     public virtual int GetId(string name) => Get(db => db.QuerySingle<int>($"SELECT [Id] FROM [dbo].[{TableName}] WHERE [Name]=@name", new { name }));
     public virtual TEntity GetById(int id) => Get(db => db.QuerySingle<TEntity>(SelectSql + " WHERE a.[Id]=@id", new { id }));
     public virtual TEntity Insert(TEntity entity) => Insert([entity]).Single();

rubberduckvba.Server/Services/rubberduckdb/FeatureServices.cs

@@ -11,7 +11,7 @@ public class FeatureServices(
     IRepository<QuickFixEntity> quickfixRepository,
     IRepository<AnnotationEntity> annotationRepository)
 {
-    public int GetId(string name) => featureRepository.GetId(name);
+    public int? GetId(string name) => featureRepository.TryGetId(name, out var id) ? id : null;
     public IEnumerable<Feature> Get(bool topLevelOnly = true)
     {
         return featureRepository.GetAll()

rubberduckvba.client/src/app/components/edit-feature/edit-feature.component.html

@@ -40,8 +40,8 @@ <h6>Edit {{action == 'edit' ? 'description' : 'summary'}}</h6>
             </div>
             <div class="row">
                 <span *ngIf="action == 'edit'" class="text-small text-muted text-end">{{feature.description.length}}</span>
-                <span *ngIf="action == 'summary'" class="text-small text-muted text-end">{{feature.shortDescription?.length ?? 0}}</span>
-            </div>
+                <span *ngIf="action == 'summary'" class="text-small text-muted text-end">{{feature.shortDescription.length}}</span>
+            </div>x
             <div *ngIf="action == 'edit'">
                 <hr />
                 <button type="button" class="btn btn-outline-secondary mb-2" (click)="onPreviewDescription()">

rubberduckvba.client/src/app/components/edit-feature/edit-feature.component.ts

@@ -80,11 +80,12 @@ export class EditFeatureComponent implements OnInit, OnChanges {
         dateInserted: '',
         dateUpdated: '',
         description: '',
-        id: 0,
+        id: undefined,
         isHidden: false,
         isNew: false,
         name: 'NewFeature1',
         title: 'New Feature',
+        shortDescription: '',
         featureId: parentId,
         featureName: parentName,
         featureTitle: parentTitle,
@@ -105,7 +106,7 @@ export class EditFeatureComponent implements OnInit, OnChanges {
 
   public onConfirmCreate(): void {
     this.modal.dismissAll();
-    this.api.saveFeature(this.subfeature).subscribe(saved => {
+    this.api.createFeature(this.subfeature).subscribe(saved => {
       window.location.reload();
     });
   }

rubberduckvba.client/src/app/model/feature.model.ts

@@ -1,5 +1,5 @@
 export interface ViewModel {
-  id: number;
+  id: number | undefined;
   dateInserted: string;
   dateUpdated: string;
   name: string;
@@ -21,7 +21,7 @@ export interface SubFeatureViewModel extends ViewModel {
 
   title: string;
   description: string;
-  shortDescription?: string | undefined;
+  shortDescription: string;
 }
 
 export interface XmlDocViewModel extends SubFeatureViewModel {
@@ -190,7 +190,7 @@ export interface AnnotationViewModel extends XmlDocViewModel {
 export type XmlDocItemViewModel = InspectionViewModel | QuickFixViewModel | AnnotationViewModel;
 
 export class ViewModelBase implements ViewModel {
-  id: number;
+  id: number | undefined;
   dateInserted: string;
   dateUpdated: string;
   name: string;
@@ -266,7 +266,7 @@ export class SubFeatureViewModelClass extends ViewModelBase implements SubFeatur
   featureTitle?: string | undefined;
   title: string;
   description: string;
-  shortDescription?: string | undefined;
+  shortDescription: string;
 
   constructor(model: SubFeatureViewModel) {
     super(model);

rubberduckvba.client/src/app/services/api-client.service.ts

@@ -83,6 +83,11 @@ export class ApiClientService {
     }));
   }
 
+  public createFeature(model: SubFeatureViewModel): Observable<SubFeatureViewModel> {
+    const url = `${environment.apiBaseUrl}features/create`;
+    return this.data.postAsync<SubFeatureViewModel, SubFeatureViewModel>(url, model).pipe(map(result => new SubFeatureViewModelClass(result as SubFeatureViewModel)));
+  }
+
   public saveFeature(model: SubFeatureViewModel): Observable<SubFeatureViewModel> {
     const url = `${environment.apiBaseUrl}features/update`;
     return this.data.postAsync<SubFeatureViewModel, SubFeatureViewModel>(url, model).pipe(map(result => new SubFeatureViewModelClass(result as SubFeatureViewModel)));