Skip to content

Commit a045f7c

Browse files
committed
switch to pdk template 2.2.0
1 parent 36e6dee commit a045f7c

File tree

8 files changed

+45
-43
lines changed

8 files changed

+45
-43
lines changed

.devcontainer/devcontainer.json

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,23 @@
1+
// For format details, see https://aka.ms/devcontainer.json. For config options, see the README at:
2+
// https://github.com/microsoft/vscode-dev-containers/tree/v0.140.1/containers/puppet
13
{
24
"name": "Puppet Development Kit (Community)",
35
"dockerFile": "Dockerfile",
46

7+
// Set *default* container specific settings.json values on container create.
58
"settings": {
6-
"terminal.integrated.profiles.linux": {
7-
"bash": {
8-
"path": "bash"
9-
}
10-
}
9+
"terminal.integrated.shell.linux": "/bin/bash"
1110
},
1211

12+
// Add the IDs of extensions you want installed when the container is created.
1313
"extensions": [
1414
"puppet.puppet-vscode",
1515
"rebornix.Ruby"
1616
]
17+
18+
// Use 'forwardPorts' to make a list of ports inside the container available locally.
19+
// "forwardPorts": [],
20+
21+
// Use 'postCreateCommand' to run commands after the container is created.
22+
// "postCreateCommand": "pdk --version",
1723
}

.pdkignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@
3939
/rakelib/
4040
/.rspec
4141
/.rubocop.yml
42+
/.travis.yml
4243
/.yardopts
4344
/spec/
4445
/.vscode/

.rubocop.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ require:
44
- rubocop-rspec
55
AllCops:
66
DisplayCopNames: true
7-
TargetRubyVersion: '2.5'
7+
TargetRubyVersion: '2.4'
88
Include:
99
- "**/*.rb"
1010
Exclude:

.sync.yml

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,13 @@ mock_with: ':rspec'
33
use_litmus: true
44
changelog_user: rtib
55
changelog_project: puppet-geoip
6-
# Rakefile:
7-
# extras:
8-
# - |
9-
# Blacksmith::RakeTask.new do |t|
10-
# t.build = false
11-
# t.tag_message_pattern = "Release v%s"
12-
# end
6+
Rakefile:
7+
extras:
8+
- |
9+
Blacksmith::RakeTask.new do |t|
10+
t.build = false
11+
t.tag_message_pattern = "Release v%s"
12+
end
1313
appveyor.yml:
1414
delete: true
1515
.gitlab-ci.yml:
@@ -19,6 +19,5 @@ appveyor.yml:
1919
Gemfile:
2020
optional:
2121
':release':
22-
- gem: 'puppet-blacksmith'
23-
- gem: 'github_changelog_generator'
24-
version: '>= 1.16.1'
22+
- gem: puppet-blacksmith
23+
- gem: github_changelog_generator

Gemfile

Lines changed: 14 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -13,35 +13,25 @@ def location_for(place_or_version, fake_version = nil)
1313
end
1414
end
1515

16+
ruby_version_segments = Gem::Version.new(RUBY_VERSION.dup).segments
17+
minor_version = ruby_version_segments[0..1].join('.')
18+
1619
group :development do
17-
gem "json", '= 2.1.0', require: false if Gem::Requirement.create(['>= 2.5.0', '< 2.7.0']).satisfied_by?(Gem::Version.new(RUBY_VERSION.dup))
18-
gem "json", '= 2.3.0', require: false if Gem::Requirement.create(['>= 2.7.0', '< 3.0.0']).satisfied_by?(Gem::Version.new(RUBY_VERSION.dup))
19-
gem "json", '= 2.5.1', require: false if Gem::Requirement.create(['>= 3.0.0', '< 3.0.5']).satisfied_by?(Gem::Version.new(RUBY_VERSION.dup))
20-
gem "json", '= 2.6.1', require: false if Gem::Requirement.create(['>= 3.1.0', '< 3.1.3']).satisfied_by?(Gem::Version.new(RUBY_VERSION.dup))
21-
gem "json", '= 2.6.3', require: false if Gem::Requirement.create(['>= 3.2.0', '< 4.0.0']).satisfied_by?(Gem::Version.new(RUBY_VERSION.dup))
22-
gem "voxpupuli-puppet-lint-plugins", '~> 4.0', require: false
23-
gem "facterdb", '~> 1.18', require: false
24-
gem "metadata-json-lint", '>= 2.0.2', '< 4.0.0', require: false
25-
gem "puppetlabs_spec_helper", '~> 5.0', require: false
26-
gem "rspec-puppet-facts", '~> 2.0', require: false
27-
gem "codecov", '~> 0.2', require: false
28-
gem "dependency_checker", '~> 0.2', require: false
29-
gem "parallel_tests", '= 3.12.1', require: false
30-
gem "pry", '~> 0.10', require: false
31-
gem "simplecov-console", '~> 0.5', require: false
32-
gem "puppet-debugger", '~> 1.0', require: false
33-
gem "rubocop", '= 1.6.1', require: false
34-
gem "rubocop-performance", '= 1.9.1', require: false
35-
gem "rubocop-rspec", '= 2.0.1', require: false
36-
gem "rb-readline", '= 0.5.5', require: false, platforms: [:mswin, :mingw, :x64_mingw]
20+
gem "json", '= 2.0.4', require: false if Gem::Requirement.create('~> 2.4.2').satisfied_by?(Gem::Version.new(RUBY_VERSION.dup))
21+
gem "json", '= 2.1.0', require: false if Gem::Requirement.create(['>= 2.5.0', '< 2.7.0']).satisfied_by?(Gem::Version.new(RUBY_VERSION.dup))
22+
gem "json", '= 2.3.0', require: false if Gem::Requirement.create(['>= 2.7.0', '< 2.8.0']).satisfied_by?(Gem::Version.new(RUBY_VERSION.dup))
23+
gem "puppet-module-posix-default-r#{minor_version}", '~> 1.0', require: false, platforms: [:ruby]
24+
gem "puppet-module-posix-dev-r#{minor_version}", '~> 1.0', require: false, platforms: [:ruby]
25+
gem "puppet-module-win-default-r#{minor_version}", '~> 1.0', require: false, platforms: [:mswin, :mingw, :x64_mingw]
26+
gem "puppet-module-win-dev-r#{minor_version}", '~> 1.0', require: false, platforms: [:mswin, :mingw, :x64_mingw]
3727
end
3828
group :system_tests do
39-
gem "puppet_litmus", '< 1.0.0', require: false, platforms: [:ruby, :x64_mingw]
40-
gem "serverspec", '~> 2.41', require: false
29+
gem "puppet-module-posix-system-r#{minor_version}", '~> 1.0', require: false, platforms: [:ruby]
30+
gem "puppet-module-win-system-r#{minor_version}", '~> 1.0', require: false, platforms: [:mswin, :mingw, :x64_mingw]
4131
end
4232
group :release do
43-
gem "puppet-blacksmith", require: false
44-
gem "github_changelog_generator", '>= 1.16.1', require: false
33+
gem "puppet-blacksmith", require: false
34+
gem "github_changelog_generator", require: false
4535
end
4636

4737
puppet_version = ENV['PUPPET_GEM_VERSION']

Rakefile

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@ end
4343

4444
PuppetLint.configuration.send('disable_relative')
4545

46-
4746
if Bundler.rubygems.find_name('github_changelog_generator').any?
4847
GitHubChangelogGenerator::RakeTask.new :changelog do |config|
4948
raise "Set CHANGELOG_GITHUB_TOKEN environment variable eg 'export CHANGELOG_GITHUB_TOKEN=valid_token_here'" if Rake.application.top_level_tasks.include? "changelog" and ENV['CHANGELOG_GITHUB_TOKEN'].nil?
@@ -87,3 +86,8 @@ EOM
8786
end
8887
end
8988

89+
Blacksmith::RakeTask.new do |t|
90+
t.build = false
91+
t.tag_message_pattern = "Release v%s"
92+
end
93+

metadata.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,6 @@
5151
"maxmind"
5252
],
5353
"pdk-version": "2.7.1",
54-
"template-url": "pdk-default#2.7.4",
55-
"template-ref": "tags/2.7.4-0-g58edf57"
54+
"template-url": "pdk-default#2.2.0",
55+
"template-ref": "tags/2.2.0-0-g2381db6"
5656
}

pdk.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
---
2+
ignore: []

0 commit comments

Comments
 (0)