Mypy fixes

Author: aaltat

requirements-dev.txt

@@ -5,4 +5,5 @@ robotstatuschecker
 flake8
 black
 isort
+mypy
 robotframework-tidy

src/robotlibcore.py

@@ -38,6 +38,10 @@ class PluginError(PythonLibCoreException):
     pass
 
 
+class NoKeywordFound(PythonLibCoreException):
+    pass
+
+
 class HybridCore:
     def __init__(self, library_components):
         self.keywords = {}
@@ -48,7 +52,7 @@ def __init__(self, library_components):
         self.__set_library_listeners(library_components)
 
     def add_library_components(self, library_components):
-        self.keywords_spec["__init__"] = KeywordBuilder.build(self.__init__)
+        self.keywords_spec["__init__"] = KeywordBuilder.build(self.__init__)  # type: ignore
         for component in library_components:
             for name, func in self.__get_members(component):
                 if callable(func) and hasattr(func, "robot_name"):
@@ -123,6 +127,8 @@ def run_keyword(self, name, args, kwargs=None):
 
     def get_keyword_arguments(self, name):
         spec = self.keywords_spec.get(name)
+        if not spec:
+            raise NoKeywordFound(f"Could not find keyword: {name}")
         return spec.argument_specification
 
     def get_keyword_tags(self, name):
@@ -132,6 +138,8 @@ def get_keyword_documentation(self, name):
         if name == "__intro__":
             return inspect.getdoc(self) or ""
         spec = self.keywords_spec.get(name)
+        if not spec:
+            raise NoKeywordFound(f"Could not find keyword: {name}")
         return spec.documentation
 
     def get_keyword_types(self, name):
@@ -142,7 +150,7 @@ def get_keyword_types(self, name):
 
     def __get_keyword(self, keyword_name):
         if keyword_name == "__init__":
-            return self.__init__
+            return self.__init__  # type: ignore
         if keyword_name.startswith("__") and keyword_name.endswith("__"):
             return None
         method = self.keywords.get(keyword_name)
@@ -234,11 +242,11 @@ def _get_kwargs(cls, arg_spec: inspect.FullArgSpec) -> list:
 
     @classmethod
     def _get_named_only_args(cls, arg_spec: inspect.FullArgSpec) -> list:
-        rf_spec = []
+        rf_spec: list = []
         kw_only_args = arg_spec.kwonlyargs if arg_spec.kwonlyargs else []
         if not arg_spec.varargs and kw_only_args:
             rf_spec.append("*")
-        kw_only_defaults = arg_spec.kwonlydefaults if arg_spec.kwonlydefaults else []
+        kw_only_defaults = arg_spec.kwonlydefaults if arg_spec.kwonlydefaults else {}
         for kw_only_arg in kw_only_args:
             if kw_only_arg in kw_only_defaults:
                 rf_spec.append((kw_only_arg, kw_only_defaults[kw_only_arg]))
@@ -320,7 +328,7 @@ def get_plugin_keywords(self, plugins: List):
         return DynamicCore(plugins).get_keyword_names()
 
     def _string_to_modules(self, modules):
-        parsed_modules = []
+        parsed_modules: list = []
         if not modules:
             return parsed_modules
         for module in modules.split(","):

tasks.py

@@ -146,6 +146,8 @@ def lint(ctx):
         command.insert(1, "--check")
         command.insert(1, "--diff")
     ctx.run(" ".join(command))
+    print("Run mypy")
+    ctx.run("mypy --exclude .venv --show-error-codes --config-file mypy.ini src/")
 
 
 @task

utest/test_robotlibcore.py

@@ -1,6 +1,6 @@
 import pytest
 
-from robotlibcore import HybridCore
+from robotlibcore import HybridCore, NoKeywordFound
 from HybridLibrary import HybridLibrary
 from DynamicLibrary import DynamicLibrary
 from DynamicTypesAnnotationsLibrary import DynamicTypesAnnotationsLibrary
@@ -117,7 +117,7 @@ def test_get_keyword_arguments():
     assert args("kwargs_only") == ["**kws"]
     assert args("all_arguments") == ["mandatory", ("default", "value"), "*varargs", "**kwargs"]
     assert args("__init__") == [("arg", None)]
-    with pytest.raises(AttributeError):
+    with pytest.raises(NoKeywordFound):
         args("__foobar__")