fix(config): correct handling of string expression at building the command line in config model

Author: d-biehl

packages/core/src/robotcode/core/utils/dataclasses.py

@@ -314,7 +314,7 @@ def __from_dict_handle_basic_types(value: Any, t: Type[Any], strict: bool) -> Tu
 
 
 def __from_dict_handle_sequence(value: Any, t: Type[Any], strict: bool) -> Tuple[Any, bool]:
-    if isinstance(value, Sequence):
+    if isinstance(value, Sequence) and not isinstance(value, str):
         args = _get_args_cached(t)
         return (_get_origin_cached(t) or t)(from_dict(v, args, strict=strict) for v in value), True
     return None, False
@@ -471,7 +471,7 @@ def from_dict(
             try:
                 return match_(**params)
             except TypeError as ex:
-                raise TypeError(f"Can't initialize class {match_!r} with parameters {params!r}: {ex}") from ex
+                raise TypeError(f"Can't initialize {match_!r} with parameters {params!r}: {ex}") from ex
 
     raise TypeError(
         "Value must be of type `"

packages/robot/src/robotcode/robot/config/model.py

@@ -291,8 +291,9 @@ def append_name(field: "dataclasses.Field[Any]", add_flag: Optional[str] = None)
                     for key, item in value.items():
                         append_name(field)
                         if isinstance(item, list):
-                            separator = ";" if any(True for s in item if ":" in s) else ":"
-                            result.append(f"{key}{separator if item else ''}{separator.join(item)}")
+                            str_item = [str(i) for i in item]
+                            separator = ";" if any(True for s in str_item if ":" in s) else ":"
+                            result.append(f"{key}{separator if item else ''}{separator.join(str_item)}")
                         else:
                             result.append(f"{key}:{item}")
                 else:

tests/robotcode/robot/config/test_profile.py

@@ -349,3 +349,29 @@ def test_set_and_evaluates_environment_var_correctly_with_vars_overridden_in_pro
     assert evaluated.variables
     assert evaluated.variables["TEST_VAR"] == "test overridden"
     assert evaluated.variables["TEST_VAR_CALCULATED"] == "9"
+
+
+def test_str_expression_works_correctly_in_lists_in_build_command_line() -> None:
+    data = """\
+        [listeners]
+        dummy_listener = [
+            { expr = "'dummy' + '/output'" },
+        ]
+        listener_with_colon = ["dummy:output"]
+        """
+    config = load_robot_config_from_robot_toml_str(data)
+    evaluated = config.combine_profiles().evaluated_with_env()
+    cmd_line = evaluated.build_command_line()
+
+    assert cmd_line
+    assert cmd_line == ["--listener", "dummy_listener:dummy/output", "--listener", "listener_with_colon;dummy:output"]
+
+
+def test_type_that_wants_alist_should_throw_an_error() -> None:
+
+    data = """\
+            [listeners]
+            listener_with_colon = "dummy:output"
+            """
+    with pytest.raises(TypeError, match=".*Value must be of type.*"):
+        load_robot_config_from_robot_toml_str(data)