Skip to content

--outputDir breaks OTA updates #22

@DmitryM-patrianna

Description

@DmitryM-patrianna

as per https://docs.revopush.org/cli/releasing-updates#output-directory-parameter

When --outputDir is specified, anything but <dir>/CodePush, all the released (and signed) bundles won't be downloaded with error

[Error: Uncaught (in promise, id: 0): "Error: Error! Public key was provided but there is no JWT signature within app bundle to verify Possible reasons, why that might happen: 
1. You've been released CodePush bundle update using version of CodePush CLI that is not support code signing.
2. You've been released CodePush bundle update without providing --privateKeyPath option."]

It appears because the sdk doesn't support custom manifest directories https://github.com/revopush/react-native-code-push/blob/12ebcc2316a6dfed199d18c559f110999e5233ee/ios/CodePush/CodePushUpdateUtils.m#L9

The possible solutions would be either

  1. Document current behavior
  2. Do not allow overriding /CodePush directory with --outputDir parameter
  3. Make the manifest folder configurable on the SDK level and document the scenario of using --outputDir explicitly

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions