Skip to content

Cannot move a node out of a comment #48

Description

@samerickson

Describe the bug

Adding this code:

  await editor.addNode(c);
  await area.translate(c.id, { x: 270, y: 200 });
  comment.addFrame("Frame", [b.id, c.id]);

To the showcase for Comments, yields the following when attempting to move a note out of a frame:

Image

You can drag a note into a frame, and that will add it to a comment, but there is no workflow for removing a node from a frame.

Current work around

My current work around is to remove the pipe for nodetranslated https://github.com/retejs/comment-plugin/blob/d158d884059dcc6bc72e25f9198c35ea1578a876/src/index.ts#L86C7-L102C8 but that has the undesirable effect of not updating comments when moving a frame that contains nodes that are also contained within a separate frame.

How to reproduce

  await editor.addNode(c);
  await area.translate(c.id, { x: 270, y: 200 });
  comment.addFrame("Frame", [b.id, c.id]);
  • Attempt to move any of the three nodes out of the two comment frames

Expected behavior

I expect to be able to drag a node out of its residing comment frame by dragging it outside the bounds of the comment frame.

Dependencies

N/A

Platform

No response

Relevant log output

Code of Conduct

  • I agree to follow this project's Code of Conduct

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions