Version 3.1.3

Fix UserController create user password var
Fix AuthController error var
Refactor MailerService

Author: renanlopescoder

package.json

@@ -1,6 +1,6 @@
 {
   "name": "node_api",
-  "version": "3.0.4",
+  "version": "3.1.3",
   "description": "Node API is production ready and open source project in Node, Express, MongoDB",
   "scripts": {
     "start": "node server.js"
@@ -18,6 +18,6 @@
     "nodemailer": "^4.2.0"
   },
   "engines": {
-    "node": "11.10.0"
+    "node": "14.0.0"
   }
 }

server.js

@@ -1,7 +1,4 @@
-"use strict";
-
 const mongoose = require("mongoose");
-const http = require("http");
 const expressServer = require("./src/config/express");
 const cluster = require("cluster");
 const OS = require("os");
@@ -14,30 +11,30 @@ class App {
     this.buildCluster(workers, autoScale);
   }
 
-  database() {
+  database = () => {
     mongoose.connect(databaseUrl, {
       useCreateIndex: true,
       useNewUrlParser: true,
       useUnifiedTopology: true
     });
 
-    mongoose.connection.on("connected", function() {
+    mongoose.connection.on("connected", () => {
       console.log("Connected Database");
     });
 
-    process.on("SIGINT", function() {
-      mongoose.connection.close(function() {
+    process.on("SIGINT", () => {
+      mongoose.connection.close(() => {
         console.log("Close database connection");
         process.exit(0);
       });
     });
 
-    mongoose.connection.on("error", function(error) {
+    mongoose.connection.on("error", error => {
       console.log("Connection Error: " + error);
     });
-  }
+  };
 
-  buildCluster(workers, autoScale) {
+  buildCluster = (workers, autoScale) => {
     if (autoScale) {
       workers = this.autoScale(workers);
     }
@@ -60,13 +57,13 @@ class App {
         console.log(`Server running on port ${PORT}`);
       });
     }
-  }
+  };
 
-  autoScale(workersByCpu) {
+  autoScale = workersByCpu => {
     const cpus = OS.cpus().length;
     const workers = cpus / workersByCpu;
     return workers;
-  }
+  };
 }
 
 /**

src/app/Controllers/AuthController.js

@@ -1,20 +1,18 @@
-"use strict";
-
 const mongoose = require("mongoose");
 const bcrypt = require("bcrypt");
 const jwt = require("jsonwebtoken");
 const model = mongoose.model("User");
 const { secret } = require("../Constants/auth");
 
 class AuthController {
-  async login(req, res) {
+  login = async (req, res) => {
     try {
       const user = await model.findOne({ email: req.body.email });
       const match = await bcrypt.compareSync(req.body.password, user.password);
 
       let token;
       if (!match) {
-        res.status(401).send({ error: error, message: "Password mismatch" });
+        res.status(401).send({ error: "error", message: "Password mismatch" });
         token = jwt.sign({ user_id: user._id }, secret, {
           expiresIn: "3h"
         });
@@ -35,11 +33,11 @@ class AuthController {
     }
   };
 
-  async verifyToken(req, res, next) {
-    const TOKEN = req.get("Authorization");
-    if (TOKEN) {
+  verifyToken = (req, res, next) => {
+    const token = req.get("Authorization");
+    if (token) {
       try {
-        let decoded = jwt.verify(token, SECRET);
+        let decoded = jwt.verify(token, secret);
         req.user = decoded;
         next();
       } catch (error) {

src/app/Controllers/ProjectController.js

@@ -1,10 +1,8 @@
-"use strict";
-
 const mongoose = require("mongoose");
 const model = mongoose.model("Project");
 
 class ProjectController {
-  async getAllProjects(req, res) {
+  async getAllProjects(_, res) {
     try {
       const projects = await model.find({});
       res.status(200).json(projects);

src/app/Controllers/UserController.js

@@ -1,40 +1,33 @@
-"use strict";
-
 const mongoose = require("mongoose");
-const mailService = require("../Services/Mail");
 const bcrypt = require("bcrypt");
 const { rounds } = require("../Constants/auth");
 const model = mongoose.model("User");
-const transporter = mailService.config();
 
-class UserController {
-  constructor() {
-    this.createUser = this.createUser.bind(this);
-    this.updateUser = this.updateUser.bind(this);
-  }
+const MailerService = require("../Services/Mail");
 
-  hashPassword(password) {
+class UserController {
+  hashPassword = password => {
     const saltRounds = bcrypt.genSaltSync(rounds);
     const hashedPassword = bcrypt.hashSync(password, saltRounds);
 
     return hashedPassword;
   };
 
-  sendWelcomeEmail(email) {
-    const content = mailService.content(email);
-    transporter.sendMail(content);
+  sendWelcomeEmail = email => {
+    const content = MailerService.welcomeMailContent(email);
+    MailerService.sendMail(content);
   };
 
-  async getAllUsers(req, res) {
+  getAllUsers = async (_, res) => {
     try {
       const users = await model.find({});
       res.status(200).json(users);
     } catch (error) {
       res.status(500).json(error);
     }
-  }
+  };
 
-  async createUser(req, res) {
+  createUser = async (req, res) => {
     const user = req.body;
     try {
       user.password = this.hashPassword(user.password);
@@ -48,18 +41,18 @@ class UserController {
     }
   };
 
-  async updateUser(req, res) {
+  updateUser = async (req, res) => {
     const user = req.body;
     try {
-      user.password = this.hashPassword(password);
+      user.password = this.hashPassword(user.password);
       await model.findByIdAndUpdate(req.params.id, user);
       res.status(200).json(user);
     } catch (error) {
       res.status(404).json(error);
     }
   };
 
-  async searchUserById(req, res) {
+  searchUserById = async (req, res) => {
     const { id } = req.params;
     try {
       const user = await model.findById(id);
@@ -69,7 +62,7 @@ class UserController {
     }
   };
 
-  async deleteUserById(req, res) {
+  deleteUserById = async (req, res) => {
     const { id } = req.params;
     try {
       await model.remove({ _id: id });

src/app/Services/Mail.js

@@ -1,30 +1,36 @@
-const nodemailer = require('nodemailer');
+const nodemailer = require("nodemailer");
 
-let mailService = {};
+class MailerService {
+  constructor() {
+    this.transport = this.config();
+  }
+
+  onfig = () =>
+    nodemailer.createTransport({
+      host: "smtp.gmail.com",
+      auth: {
+        user: "rest.api.node@gmail.com",
+        pass: "pnzkxchwwqddzhve"
+      }
+    });
 
-mailService.config = () => (
-  nodemailer.createTransport({
-    host: 'smtp.gmail.com',
-    auth: {
-        user: 'rest.api.node@gmail.com',
-        pass: 'pnzkxchwwqddzhve'
-    }
-  })
-);
+  sendMail = mail => {
+    this.transport.sendMail(mail);
+  };
 
-mailService.content = userMail => (
-  {
+  welcomeMailContent = userMail => ({
     from: '"Node API" <rest-api-node@gmail.com>',
     to: userMail,
-    subject: 'Welcome to Node API',
-    html: '<p>Welcome to Node API!</p>'
-      +'<p>This API is developed to provide Front End developers with a server and database configurations for connection testing and to provide a visualization of the data streamlining for the development process. The API provides HTTP methods via AJAX requests to collect, insert and update the given data.</p>'
-      +'Github: <a href="https://github.com/renanlopescoder/rest-api-node">rest-api-node</a>'
-      +'<br><br>Happy Hack!,'
-      +'<br>Node API Team 🤖'
-      +'<br><br><img src="http://pluspng.com/img-png/github-octocat-logo-vector-png--896.jpg" alt="Github Logo" height="82" width="82">'
-      +'<img src="https://raw.githubusercontent.com/renanlopescoder/rest-api-node/master/logo.png" alt="Node Logo" height="65" width="150">'
-  }
-);
+    subject: "Welcome to Node API",
+    html:
+      "<p>Welcome to Node API!</p>" +
+      "<p>This API is developed to provide Front End developers with a server and database configurations for connection testing and to provide a visualization of the data streamlining for the development process. The API provides HTTP methods via AJAX requests to collect, insert and update the given data.</p>" +
+      'Github: <a href="https://github.com/renanlopescoder/rest-api-node">rest-api-node</a>' +
+      "<br><br>Happy Hack!," +
+      "<br>Node API Team 🤖" +
+      '<br><br><img src="http://pluspng.com/img-png/github-octocat-logo-vector-png--896.jpg" alt="Github Logo" height="82" width="82">' +
+      '<img src="https://raw.githubusercontent.com/renanlopescoder/rest-api-node/master/logo.png" alt="Node Logo" height="65" width="150">'
+  });
+}
 
-module.exports = mailService
+module.exports = new MailerService();