cache_key check for only one matched against multiple candidates fix

Author: Shubham Kaudewar

redis/cache.py

@@ -216,10 +216,13 @@ def delete_by_redis_keys(
                 except UnicodeDecodeError:
                     pass  # Non-UTF-8 bytes, skip str version
 
-            for cache_key in self._cache:
+            matched = False
+            for cache_key in list(self._cache):
                 if any(candidate in cache_key.redis_keys for candidate in candidates):
                     keys_to_delete.append(cache_key)
-                    response.append(True)
+                    matched = True
+
+            response.append(matched)
 
         for key in keys_to_delete:
             self._cache.pop(key)

tests/test_cache.py

@@ -1034,7 +1034,7 @@ def test_delete_by_redis_keys_removes_associated_entries(self, mock_connection):
             )
         )
 
-        assert cache.delete_by_redis_keys([b"foo", b"foo1"]) == [True, True, True]
+        assert cache.delete_by_redis_keys([b"foo", b"foo1"]) == [True, True]
         assert len(cache.collection) == 1
         assert cache.get(cache_key4).cache_value == b"bar3"