Skip to content

Commit 9e8e2ff

Browse files
committed
The documentation is now cleaned up:
Only the Query-based insert_one pattern is shown for Redis and Vector Sets. The old (vector_id, vector, metadata) signatures are removed. A base_client insert_one stub is included for clarity and completeness.
1 parent fb5db46 commit 9e8e2ff

File tree

1 file changed

+12
-7
lines changed

1 file changed

+12
-7
lines changed

docs/MIXED_WORKLOAD_IMPLEMENTATION_PLAN.md

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,14 @@ def worker_function(self, distance, search_one, insert_one, chunk, result_queue,
6868
**File 3: `BaseSearcher.search_all()`**
6969
- When creating worker processes, pass `search_one`, `insert_one`, and `insert_fraction` as arguments to each worker.
7070

71-
**File 4: Engine-specific `insert_one` implementations** (~5 lines each)
71+
**File 4: Base and Engine-specific `insert_one` implementations**
7272
```python
73+
# In engine/base_client/search.py
74+
@classmethod
75+
def insert_one(cls, query):
76+
"""Insert a single vector - must be implemented by each engine."""
77+
raise NotImplementedError("insert_one must be implemented by each engine")
78+
7379
# Example: engine/clients/redis/search.py
7480
@classmethod
7581
def insert_one(cls, query):
@@ -80,14 +86,13 @@ def insert_one(cls, query):
8086
mapping={"vector": query.vector, **(getattr(query, 'metadata', {}) or {})}
8187
)
8288

83-
# Example: engine/clients/qdrant/search.py
89+
# Example: engine/clients/vectorsets/search.py
8490
@classmethod
8591
def insert_one(cls, query):
86-
"""Qdrant-specific single vector insert from a Query object"""
87-
cls.client.upsert(
88-
collection_name=QDRANT_COLLECTION_NAME,
89-
points=[{"id": query.id, "vector": query.vector, "payload": getattr(query, 'metadata', {}) or {}}],
90-
wait=False,
92+
"""Redis Vector Sets single vector insert from a Query object"""
93+
# Extract params as needed from query or config
94+
cls.client.execute_command(
95+
"VADD", "idx", "FP32", query.vector, query.id, "NOQUANT", "M", 16, "EF", 200, "CAS"
9196
)
9297
```
9398

0 commit comments

Comments
 (0)