Added limit pushdown tests

Author: julien

subprojects/trino-redisearch/src/main/java/com/redis/trino/RediSearchPageSource.java

@@ -63,7 +63,7 @@ public RediSearchPageSource(RediSearchSession rediSearchSession, RediSearchTable
 			List<RediSearchColumnHandle> columns) {
 		this.columnNames = columns.stream().map(RediSearchColumnHandle::getName).collect(toList());
 		this.columnTypes = columns.stream().map(RediSearchColumnHandle::getType).collect(toList());
-		this.cursor = rediSearchSession.execute(tableHandle, columns).iterator();
+		this.cursor = rediSearchSession.execute(tableHandle).iterator();
 		this.currentDoc = null;
 		this.pageBuilder = new PageBuilder(columnTypes);
 	}
@@ -117,7 +117,6 @@ private void appendTo(Type type, String value, BlockBuilder output) {
 			output.appendNull();
 			return;
 		}
-
 		Class<?> javaType = type.getJavaType();
 		if (javaType == boolean.class) {
 			type.writeBoolean(output, Boolean.parseBoolean(value));

subprojects/trino-redisearch/src/main/java/com/redis/trino/RediSearchSession.java

@@ -189,8 +189,7 @@ private Type columnType(TypeSignature typeSignature) {
 		return typeManager.fromSqlType(typeSignature.toString());
 	}
 
-	public SearchResults<String, String> execute(RediSearchTableHandle tableHandle,
-			List<RediSearchColumnHandle> columns) {
+	public SearchResults<String, String> execute(RediSearchTableHandle tableHandle) {
 		String index = tableHandle.getSchemaTableName().getTableName();
 		String query = RediSearchQueryBuilder.buildQuery(tableHandle.getConstraint());
 		Builder<String, String> options = SearchOptions.<String, String>builder();

subprojects/trino-redisearch/src/main/java/com/redis/trino/RediSearchTableHandle.java

@@ -1,18 +1,20 @@
 package com.redis.trino;
 
+import static java.util.Objects.requireNonNull;
+
+import java.util.Objects;
+import java.util.OptionalInt;
+
 import com.fasterxml.jackson.annotation.JsonCreator;
 import com.fasterxml.jackson.annotation.JsonProperty;
+
 import io.trino.spi.connector.ColumnHandle;
 import io.trino.spi.connector.ConnectorTableHandle;
 import io.trino.spi.connector.SchemaTableName;
 import io.trino.spi.predicate.TupleDomain;
 
-import java.util.Objects;
-import java.util.OptionalInt;
-
-import static java.util.Objects.requireNonNull;
-
 public class RediSearchTableHandle implements ConnectorTableHandle {
+
 	private final SchemaTableName schemaTableName;
 	private final TupleDomain<ColumnHandle> constraint;
 	private final OptionalInt limit;

subprojects/trino-redisearch/src/test/java/com/redis/trino/TestRediSearchConnectorTest.java

@@ -81,7 +81,7 @@ protected boolean hasBehavior(TestingConnectorBehavior connectorBehavior) {
 			return true;
 
 		case SUPPORTS_LIMIT_PUSHDOWN:
-			return false;
+			return true;
 
 		case SUPPORTS_PREDICATE_PUSHDOWN_WITH_VARCHAR_INEQUALITY:
 			return false;
@@ -102,14 +102,20 @@ protected TestTable createTableWithDefaultColumns() {
 		throw new SkipException("test disabled for RediSearch");
 	}
 
-	@Override
-	public void testLimit() {
-		// ignore
-	}
-
-	@Override
+	@Test
 	public void testLimitMax() {
-		// ignore
+		int maxLimit = 1000000;
+		// max int
+		assertQuery("SELECT orderkey FROM orders LIMIT " + maxLimit);
+		assertQuery("SELECT orderkey FROM orders ORDER BY orderkey LIMIT " + maxLimit);
+
+		// max long; a connector may attempt a pushdown while remote system may not
+		// accept such high limit values
+		assertQuery("SELECT nationkey FROM nation LIMIT " + maxLimit, "SELECT nationkey FROM nation");
+		// Currently this is not supported but once it's supported, it should be tested
+		// with connectors as well
+		assertQueryFails("SELECT nationkey FROM nation ORDER BY nationkey LIMIT " + Long.MAX_VALUE,
+				"ORDER BY LIMIT > 2147483647 is not supported");
 	}
 
 	@Override