Skip to content

Commit ff73f45

Browse files
authored
Merge pull request #57 from redis-field-engineering/v2/unneeded-v1-metrcis
removing extra v1 metrics
2 parents 76f132b + d973d10 commit ff73f45

11 files changed

+18
-20132
lines changed

datadog_v2/kickstarter/terraform/gcp/main.tf

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ resource "google_compute_instance" "datadog-agent-vm"{
1818
zone = var.zone
1919
boot_disk {
2020
initialize_params {
21-
image = "ubuntu-os-cloud/ubuntu-2004-lts"
21+
image = "ubuntu-2004-focal-v20240731"
2222
}
2323
}
2424

@@ -41,7 +41,7 @@ resource "null_resource" "install_datadog_agent" {
4141

4242
inline = [
4343
"DD_API_KEY=${var.datadog_api_key} DD_SITE=\"${var.datadog_site}\" bash -c \"$(curl -L https://install.datadoghq.com/scripts/install_script_agent7.sh)\"",
44-
"git clone https://github.com/redis-field-engineering/datadog-integrations-extras",
44+
"git clone ${var.repo}",
4545
# install python 3.12
4646
"sudo apt update",
4747
"sudo apt install -y software-properties-common",
@@ -53,7 +53,7 @@ resource "null_resource" "install_datadog_agent" {
5353
"pip install build",
5454
"cd datadog-integrations-extras",
5555
# "git checkout redis_enterprise_prometheus",
56-
"git checkout v2-metrics-extended",
56+
"git checkout ${var.branch}",
5757
"cd ${var.datadog_integration_name}",
5858
"python3.12 -m build --wheel",
5959
"sudo datadog-agent integration install -r -w ./dist/datadog_redis_enterprise_prometheus-2.0.1-py3-none-any.whl",

datadog_v2/kickstarter/terraform/gcp/variables.tf

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,3 +56,15 @@ variable "redis_fqdn" {
5656
description = "The fully qualified domain name (FQDN) of the Redis cluster"
5757
type = string
5858
}
59+
60+
variable "repo" {
61+
description = "Git repository URL for the Datadog integration"
62+
type = string
63+
default = "https://github.com/DataDog/integrations-extras"
64+
}
65+
66+
variable "branch" {
67+
description = "Git branch to checkout for the Datadog integration"
68+
type = string
69+
default = "master"
70+
}

grafana_v2/dashboards/grafana_v9-11/software/basic/redis-software-active-active-dashboard_v9-11.json

Lines changed: 0 additions & 186 deletions
Original file line numberDiff line numberDiff line change
@@ -235,99 +235,6 @@
235235
"title": "CRDT Ingress",
236236
"type": "timeseries"
237237
},
238-
{
239-
"datasource": {
240-
"type": "prometheus",
241-
"uid": "${DS_PROMETHEUS}"
242-
},
243-
"fieldConfig": {
244-
"defaults": {
245-
"color": {
246-
"mode": "palette-classic"
247-
},
248-
"custom": {
249-
"axisCenteredZero": false,
250-
"axisColorMode": "text",
251-
"axisLabel": "",
252-
"axisPlacement": "auto",
253-
"barAlignment": 0,
254-
"drawStyle": "line",
255-
"fillOpacity": 0,
256-
"gradientMode": "none",
257-
"hideFrom": {
258-
"legend": false,
259-
"tooltip": false,
260-
"viz": false
261-
},
262-
"lineInterpolation": "linear",
263-
"lineWidth": 1,
264-
"pointSize": 5,
265-
"scaleDistribution": {
266-
"type": "linear"
267-
},
268-
"showPoints": "auto",
269-
"spanNulls": false,
270-
"stacking": {
271-
"group": "A",
272-
"mode": "none"
273-
},
274-
"thresholdsStyle": {
275-
"mode": "off"
276-
}
277-
},
278-
"mappings": [],
279-
"thresholds": {
280-
"mode": "absolute",
281-
"steps": [
282-
{
283-
"color": "green",
284-
"value": null
285-
},
286-
{
287-
"color": "red",
288-
"value": 80
289-
}
290-
]
291-
},
292-
"unit": "decbytes"
293-
},
294-
"overrides": []
295-
},
296-
"gridPos": {
297-
"h": 6,
298-
"w": 8,
299-
"x": 12,
300-
"y": 0
301-
},
302-
"id": 7,
303-
"options": {
304-
"legend": {
305-
"calcs": [],
306-
"displayMode": "list",
307-
"placement": "bottom",
308-
"showLegend": true
309-
},
310-
"tooltip": {
311-
"mode": "single",
312-
"sort": "none"
313-
}
314-
},
315-
"targets": [
316-
{
317-
"datasource": {
318-
"type": "prometheus",
319-
"uid": "${DS_PROMETHEUS}"
320-
},
321-
"editorMode": "builder",
322-
"expr": "bdb_crdt_syncer_egress_bytes",
323-
"legendFormat": "{{cluster}}",
324-
"range": true,
325-
"refId": "A"
326-
}
327-
],
328-
"title": "CRDT Egress",
329-
"type": "timeseries"
330-
},
331238
{
332239
"datasource": {
333240
"type": "prometheus",
@@ -553,99 +460,6 @@
553460
"title": "CRDT Ingress (Decompressed)",
554461
"type": "timeseries"
555462
},
556-
{
557-
"datasource": {
558-
"type": "prometheus",
559-
"uid": "${DS_PROMETHEUS}"
560-
},
561-
"fieldConfig": {
562-
"defaults": {
563-
"color": {
564-
"mode": "palette-classic"
565-
},
566-
"custom": {
567-
"axisCenteredZero": false,
568-
"axisColorMode": "text",
569-
"axisLabel": "",
570-
"axisPlacement": "auto",
571-
"barAlignment": 0,
572-
"drawStyle": "line",
573-
"fillOpacity": 0,
574-
"gradientMode": "none",
575-
"hideFrom": {
576-
"legend": false,
577-
"tooltip": false,
578-
"viz": false
579-
},
580-
"lineInterpolation": "linear",
581-
"lineWidth": 1,
582-
"pointSize": 5,
583-
"scaleDistribution": {
584-
"type": "linear"
585-
},
586-
"showPoints": "auto",
587-
"spanNulls": false,
588-
"stacking": {
589-
"group": "A",
590-
"mode": "none"
591-
},
592-
"thresholdsStyle": {
593-
"mode": "off"
594-
}
595-
},
596-
"mappings": [],
597-
"thresholds": {
598-
"mode": "absolute",
599-
"steps": [
600-
{
601-
"color": "green",
602-
"value": null
603-
},
604-
{
605-
"color": "red",
606-
"value": 80
607-
}
608-
]
609-
},
610-
"unit": "decbytes"
611-
},
612-
"overrides": []
613-
},
614-
"gridPos": {
615-
"h": 6,
616-
"w": 8,
617-
"x": 12,
618-
"y": 6
619-
},
620-
"id": 8,
621-
"options": {
622-
"legend": {
623-
"calcs": [],
624-
"displayMode": "list",
625-
"placement": "bottom",
626-
"showLegend": true
627-
},
628-
"tooltip": {
629-
"mode": "single",
630-
"sort": "none"
631-
}
632-
},
633-
"targets": [
634-
{
635-
"datasource": {
636-
"type": "prometheus",
637-
"uid": "${DS_PROMETHEUS}"
638-
},
639-
"editorMode": "builder",
640-
"expr": "bdb_crdt_syncer_egress_bytes_decompressed",
641-
"legendFormat": "{{cluster}}",
642-
"range": true,
643-
"refId": "A"
644-
}
645-
],
646-
"title": "CRDT Egress (Decompressed)",
647-
"type": "timeseries"
648-
},
649463
{
650464
"datasource": {
651465
"type": "prometheus",

grafana_v2/dashboards/grafana_v9-11/software/basic/redis-software-cluster-dashboard_v9-11.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -752,7 +752,7 @@
752752
"name": "cluster",
753753
"options": [],
754754
"query": {
755-
"query": "label_values(node_up,cluster)",
755+
"query": "label_values(redis_server_up,cluster)",
756756
"refId": "Redis-Enterprise-cluster-Variable-Query"
757757
},
758758
"refresh": 1,

grafana_v2/dashboards/grafana_v9-11/software/basic/redis-software-database-dashboard_v9-11.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -874,7 +874,7 @@
874874
"name": "cluster",
875875
"options": [],
876876
"query": {
877-
"query": "label_values(node_up,cluster)",
877+
"query": "label_values(redis_server_up,cluster)",
878878
"refId": "Redis-Enterprise-cluster-Variable-Query"
879879
},
880880
"refresh": 1,

grafana_v2/dashboards/grafana_v9-11/software/basic/redis-software-shard-dashboard_v9-11.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6020,7 +6020,7 @@
60206020
"name": "cluster",
60216021
"options": [],
60226022
"query": {
6023-
"query": "label_values(node_up,cluster)",
6023+
"query": "label_values(redis_server_up,cluster)",
60246024
"refId": "Redis-Enterprise-cluster-Variable-Query"
60256025
},
60266026
"refresh": 1,

0 commit comments

Comments
 (0)