Rework need to release for debian

Author: Peter-Sh

src/redis_release/bht/behaviours.py

@@ -874,26 +874,42 @@ def __init__(
     ) -> None:
         self.release_meta = release_meta
         self.package_meta = package_meta
+        self.release_version: Optional[RedisVersion] = None
         super().__init__(name=name, log_prefix=log_prefix)
 
+    def initialise(self) -> None:
+        if self.package_meta.release_type is not None:
+            return
+        if self.release_meta.tag is None:
+            self.logger.error("Release tag is not set")
+            return
+        self.release_version = RedisVersion.parse(self.release_meta.tag)
+
     def update(self) -> Status:
+        result: Status = Status.FAILURE
+
         if self.package_meta.release_type is not None:
-            if self.log_once(
-                "release_type_detected", self.package_meta.ephemeral.log_once_flags
-            ):
-                self.logger.info(
-                    f"Detected release type: {self.package_meta.release_type}"
-                )
-            return Status.SUCCESS
-        if self.release_meta.tag and re.search(r"-int\d*$", self.release_meta.tag):
-            self.package_meta.release_type = ReleaseType.INTERNAL
+            result = Status.SUCCESS
+            self.feedback_message = f"Release type: {self.package_meta.release_type}"
+        elif self.release_version is not None:
+            if self.release_version.is_internal:
+                self.package_meta.release_type = ReleaseType.INTERNAL
+            else:
+                self.package_meta.release_type = ReleaseType.PUBLIC
+            result = Status.SUCCESS
+            self.feedback_message = f"Release type: {self.package_meta.release_type}"
         else:
-            self.package_meta.release_type = ReleaseType.PUBLIC
-        self.log_once(
+            self.feedback_message = "Failed to detect release type"
+            result = Status.FAILURE
+
+        if self.log_once(
             "release_type_detected", self.release_meta.ephemeral.log_once_flags
-        )
-        self.logger.info(f"Detected release type: {self.package_meta.release_type}")
-        return Status.SUCCESS
+        ):
+            if result == Status.SUCCESS:
+                self.logger.info(f"[green]{self.feedback_message}[/green]")
+            else:
+                self.logger.error(f"[red]{self.feedback_message}[/red]")
+        return result
 
 
 class IsForceRebuild(LoggingAction):

src/redis_release/bht/behaviours_debian.py

@@ -1,7 +1,10 @@
+from typing import Optional
+
 from py_trees.common import Status
 
 from redis_release.bht.behaviours import LoggingAction
 from redis_release.bht.state import PackageMeta, ReleaseMeta
+from redis_release.models import RedisVersion
 
 # Conditions
 
@@ -18,8 +21,39 @@ def __init__(
     ) -> None:
         self.package_meta = package_meta
         self.release_meta = release_meta
+        self.release_version: Optional[RedisVersion] = None
+
         super().__init__(name=name, log_prefix=log_prefix)
 
+    def initialise(self) -> None:
+        if self.release_meta.tag is None:
+            self.logger.error("Release tag is not set")
+            return
+        if self.release_version is not None:
+            return
+
+        if self.release_meta.tag == "unstable":
+            return
+        try:
+            self.release_version = RedisVersion.parse(self.release_meta.tag)
+        except ValueError as e:
+            self.logger.error(f"Failed to parse release tag: {e}")
+            return
+        pass
+
     def update(self) -> Status:
-        # Debian packages are always released
-        return Status.SUCCESS
+        result: Status = Status.FAILURE
+        if self.release_meta.tag is None:
+            self.feedback_message = "Release tag is not set"
+            result = Status.FAILURE
+        if self.release_meta.tag == "unstable":
+            self.feedback_message = "Skip unstable release for debian"
+            result = Status.FAILURE
+
+        if self.release_version is not None:
+            self.feedback_message = "Need to release debian"
+            result = Status.SUCCESS
+
+        if self.log_once("need_to_release", self.package_meta.ephemeral.log_once_flags):
+            self.logger.info(self.feedback_message)
+        return result