fix(checkpoint): update blob access to support JSON path syntax #117
+19
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified the AsyncRedisSaver to access the blob attribute using JSON path syntax. Enhanced the sorting mechanism for parent checkpoints and ensured the results map correctly extracts type and blob pairs, accommodating both direct and JSON path access. This improves compatibility and consistency in data handling.
bsbodden
approved these changes
Nov 14, 2025
Contributor
bsbodden
left a comment
bsbodden
left a comment
There was a problem hiding this comment.
LGTM, thank you for the contribution!
bsbodden
added a commit
that referenced
this pull request
Nov 14, 2025
Adds comprehensive regression tests for Issue #116 where AsyncRedisSaver would raise AttributeError when accessing blob attributes in _abatch_load_pending_sends. Tests verify: - Correct handling of $.blob JSON path attribute syntax - Graceful fallback when blob attributes are missing - Proper mocking of Redis Document responses These tests would have caught the bug fixed in PR #117. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #116
Problem
This pull request fixes an AttributeError raised when using
AsyncRedisSaverand callingaget_state_history().Solution
The fix aligns the async implementation with the existing sync version.
Result
aget_state_history()and related async checkpoint operations now work reliably without raising attribute errorsThank you for maintaining this great project!
I’ve mirrored the sync version’s logic and verified that the async implementation now behaves consistently.