Skip to content

Commit 57989ca

Browse files
committed
Claude review: Updates for code issues claude found when asked to look
for bugs.
1 parent 9e69d4f commit 57989ca

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

save_results

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ opts=$(getopt \
9090
-- "$@"
9191
)
9292

93-
eval set --$opts
93+
eval set -- "$opts"
9494

9595
if [[ $? -ne 0 ]] || [[ $# -eq 1 ]]; then
9696
usage $0
@@ -158,7 +158,7 @@ if [[ $curdir == "" ]]; then
158158
curdir=`pwd`
159159
fi
160160
if [[ $user == "" ]] && [[ $home_root == "" ]]; then
161-
$home_root=$curdir
161+
home_root=$curdir
162162
fi
163163
export_results="$home_root/$user/export_results"
164164
if [[ ! -d $export_results ]]; then
@@ -176,11 +176,11 @@ which tuned-adm >> /dev/null 2>&1
176176
if [[ $? -ne 0 ]]; then
177177
echo tuned-adm not available > ~/tuned_after
178178
else
179-
tuned-adm active | cut -d: -f 2 | sed "s/ //g" > ~/tuned_after
179+
tuned-adm active | cut -d: -f 2 | sed "s/ //g" > ~/tuned_after
180180
fi
181181
diff ~/tuned_before ~/tuned_after > $RESULTS_PATH/tuned_setting
182182

183-
if [[ $? -ne -0 ]]; then
183+
if [[ $? -ne 0 ]]; then
184184
echo 'Tuned settings have changed!!!!'
185185
echo Start of run
186186
cat ~/tuned_before
@@ -200,9 +200,9 @@ if [[ $other_files != "" ]]; then
200200
fi
201201

202202
if [[ $tar_file != "" ]]; then
203-
pushd $RESULTS_PATH
203+
pushd $RESULTS_PATH > /dev/null
204204
tar xf $tar_file
205-
popd
205+
popd > /dev/null
206206
fi
207207
if [[ $copy_dir != "" ]]; then
208208
cp -R $copy_dir $RESULTS_PATH
@@ -228,8 +228,8 @@ cd /tmp
228228
#
229229
# Provide a common pull for Zathra.
230230
#
231-
if [[ -f test_wrapper_results_${test}.zip ]]; then
232-
rm test_wrapper_results_${test}.zip test_wrapper_results_pbench_${test}.zip
231+
if [[ -f test_wrapper_results_${test_name}.zip ]]; then
232+
rm test_wrapper_results_${test_name}.zip
233233
fi
234234
zip results_${test_name}.zip results_${test_name}_${tuned_setting}.tar
235235
link_files results_${test_name}.zip results_pbench_${test_name}.zip

0 commit comments

Comments
 (0)