Incorrect behavior of ThrowWithPreviousExceptionRector

[eexit]

Bug Report

Subject	Details
Rector version	last dev-main/2.3.8
Installed as	composer dependency

Minimal PHP Code Causing Issue

See https://getrector.com/demo/f5724dc1-f9d3-4950-ba1d-d7fee6331452

<?php declare(strict_types=1);

namespace GraphQL\Error;

use GraphQL\Language\AST\Node;
use GraphQL\Language\Source;

class Error extends \Exception
{
    /**
     * @param iterable<array-key, Node|null>|Node|null $nodes
     * @param array<int, int>|null $positions
     * @param list<int|string>|null $path
     * @param array<string, mixed>|null $extensions
     * @param list<int|string>|null $unaliasedPath
     */
    public function __construct(
        string $message = '',
        $nodes = null,
        ?Source $source = null,
        ?array $positions = null,
        ?array $path = null,
        ?\Throwable $previous = null,
        ?array $extensions = null,
        ?array $unaliasedPath = null
    ) {
        parent::__construct($message, 0, $previous);
    }
}

try {
    throw new \InvalidArgumentException('foo');
} catch (\InvalidArgumentException $e) {
    throw new Error(message: 'Some error message', previous: $e);
}

Responsible rules

• ThrowWithPreviousExceptionRector

Expected Behavior

No change.

[samsonasik]

That is expected, the code needs follow previous exception's, and named argument is follow last definition. See the rule definition itself

https://getrector.com/rule-detail/throw-with-previous-exception-rector

[eexit]

Hello to you @samsonasik, I hope you're having a nice day.

Please, check the code I've provided again: the Error class does not have any code argument, so I do not expect Rector to introduce it.

Thanks.

[samsonasik]

I see, reopen then :)

[laurentmuller]

Hi,

I have the same issue with Twig error:

namespace Twig\Error;

class Error extends \Exception
{
    public function __construct(string $message, int $lineno = -1, ?Source $source = null, ?\Throwable $previous = null)
    {
        // ...
    }
}

In my code:

throw new Error(message: 'My message', previous: $e);

Rector:

- throw new Error(message: 'My message', previous: $e);
+ throw new Error(message: 'My message', code: $e->getCode(), previous: $e);

But the code argument does not exist!

[samsonasik]

@laurentmuller I created PR:

• [CodeQuality] Skip no code parameter on custom Throwable instance on ThrowWithPreviousExceptionRector rector-src#7912

for it :)