From 489f594f50fd759af58da7f8d4bfb46d2860c654 Mon Sep 17 00:00:00 2001 From: Abdul Malik Ikhsan Date: Fri, 20 Feb 2026 22:01:59 +0700 Subject: [PATCH] [Php83] Fix infinite add - remove #[Override] on tearDown() method on AddOverrideAttributeToOverriddenMethodsRector when combined with NoSetupWithParentCallOverrideRector --- .../Fixture/skip_teardown_override.php.inc | 16 ++++++++++++++++ .../Source/SomeAbstractTestCase.php | 5 +++++ ...verrideAttributeToOverriddenMethodsRector.php | 2 +- 3 files changed, 22 insertions(+), 1 deletion(-) create mode 100644 rules-tests/Php83/Rector/ClassMethod/AddOverrideAttributeToOverriddenMethodsRector/Fixture/skip_teardown_override.php.inc diff --git a/rules-tests/Php83/Rector/ClassMethod/AddOverrideAttributeToOverriddenMethodsRector/Fixture/skip_teardown_override.php.inc b/rules-tests/Php83/Rector/ClassMethod/AddOverrideAttributeToOverriddenMethodsRector/Fixture/skip_teardown_override.php.inc new file mode 100644 index 00000000000..8b6cf38fca9 --- /dev/null +++ b/rules-tests/Php83/Rector/ClassMethod/AddOverrideAttributeToOverriddenMethodsRector/Fixture/skip_teardown_override.php.inc @@ -0,0 +1,16 @@ +isName($classMethod, 'setUp') && $this->parentClassAnalyzer->hasParentCall($classMethod); + return $this->isNames($classMethod, ['setUp', 'tearDown']) && $this->parentClassAnalyzer->hasParentCall($classMethod); } private function shouldSkipParentClassMethod(ClassReflection $parentClassReflection, ClassMethod $classMethod): bool