From a7273c7f31280917b6ae583bd528eea32c2879c9 Mon Sep 17 00:00:00 2001
From: Tomas Votruba <tomas.vot@gmail.com>
Date: Wed, 12 Aug 2026 12:03:07 +0200
Subject: [PATCH] [PHPUnit60] Skip imported PHPUnit assert functions in
 AddDoesNotPerformAssertionToNonAssertingTestRector

---
 .../skip_imported_assert_function.php.inc     | 20 +++++++++++++
 src/NodeAnalyzer/AssertCallAnalyzer.php       | 30 +++++++++++++++++++
 2 files changed, 50 insertions(+)
 create mode 100644 rules-tests/PHPUnit60/Rector/ClassMethod/AddDoesNotPerformAssertionToNonAssertingTestRector/Fixture/skip_imported_assert_function.php.inc

diff --git a/rules-tests/PHPUnit60/Rector/ClassMethod/AddDoesNotPerformAssertionToNonAssertingTestRector/Fixture/skip_imported_assert_function.php.inc b/rules-tests/PHPUnit60/Rector/ClassMethod/AddDoesNotPerformAssertionToNonAssertingTestRector/Fixture/skip_imported_assert_function.php.inc
new file mode 100644
index 00000000..255d1bb6
--- /dev/null
+++ b/rules-tests/PHPUnit60/Rector/ClassMethod/AddDoesNotPerformAssertionToNonAssertingTestRector/Fixture/skip_imported_assert_function.php.inc
@@ -0,0 +1,20 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\PHPUnit60\Rector\ClassMethod\AddDoesNotPerformAssertionToNonAssertingTestRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+
+use function PHPUnit\Framework\assertNotNull;
+
+final class SkipImportedAssertFunction extends TestCase
+{
+    public function testSomething(): void
+    {
+        assertNotNull(true);
+    }
+
+    public function testFullyQualified(): void
+    {
+        \PHPUnit\Framework\assertTrue(true);
+    }
+}
diff --git a/src/NodeAnalyzer/AssertCallAnalyzer.php b/src/NodeAnalyzer/AssertCallAnalyzer.php
index 9b756f4c..02db1f97 100644
--- a/src/NodeAnalyzer/AssertCallAnalyzer.php
+++ b/src/NodeAnalyzer/AssertCallAnalyzer.php
@@ -5,6 +5,7 @@
 namespace Rector\PHPUnit\NodeAnalyzer;
 
 use PhpParser\Node;
+use PhpParser\Node\Expr\FuncCall;
 use PhpParser\Node\Expr\MethodCall;
 use PhpParser\Node\Expr\StaticCall;
 use PhpParser\Node\Identifier;
@@ -21,6 +22,11 @@ final class AssertCallAnalyzer
 {
     private const int MAX_NESTED_METHOD_CALL_LEVEL = 5;
 
+    /**
+     * @see https://docs.phpunit.de/en/12.4/assertions.html
+     */
+    private const string PHPUNIT_FUNCTION_NAMESPACE = 'PHPUnit\Framework\\';
+
     /**
      * @var string[]
      */
@@ -134,10 +140,34 @@ private function hasDirectAssertOrMockCall(ClassMethod $classMethod): bool
                 return $this->isAssertMethodCall($node);
             }
 
+            // standalone function assert, e.g. "use function PHPUnit\Framework\assertNotNull;"
+            if ($node instanceof FuncCall) {
+                return $this->isAssertFuncCall($node);
+            }
+
             return false;
         });
     }
 
+    private function isAssertFuncCall(FuncCall $funcCall): bool
+    {
+        $funcCallName = $this->nodeNameResolver->getName($funcCall);
+        if (! is_string($funcCallName)) {
+            return false;
+        }
+
+        if (! str_starts_with($funcCallName, self::PHPUNIT_FUNCTION_NAMESPACE)) {
+            return false;
+        }
+
+        $shortFuncCallName = substr($funcCallName, strlen(self::PHPUNIT_FUNCTION_NAMESPACE));
+
+        return array_any(
+            self::ASSERT_METHOD_NAME_PREFIXES,
+            fn (string $assertMethodNamePrefix): bool => str_starts_with($shortFuncCallName, $assertMethodNamePrefix)
+        );
+    }
+
     private function hasNestedAssertCall(ClassMethod $classMethod): bool
     {
         $currentClassMethod = $classMethod;