Refactor PRListModal to ensure hooks are called before early returns; implement Escape key functionality to close modal

Author: yashksaini-coder

src/components/dashboard/LeaderBoard/PRListModal.tsx

@@ -40,10 +40,9 @@ export default function PRListModal({
   const { getFilteredPRsForContributor, currentTimeFilter } =
     useCommunityStatsContext();
 
-  if (!contributor) return null;
-
   // Get filtered PRs instead of using contributor.prDetails
   // Use useMemo to prevent infinite loops
+  // IMPORTANT: All hooks must be called before any early returns
   const filteredPRs = useMemo(() => {
     if (!contributor) return [];
     return getFilteredPRsForContributor(contributor.username);
@@ -54,6 +53,25 @@ export default function PRListModal({
     return filteredPRs.reduce((sum, pr) => sum + pr.points, 0);
   }, [filteredPRs]);
 
+  // Close modal on Escape key press
+  useEffect(() => {
+    if (!isOpen) return;
+    const handleEsc = (event: KeyboardEvent) => {
+      if (event.key === "Escape") {
+        onClose();
+      }
+    };
+
+    window.addEventListener("keydown", handleEsc);
+    return () => {
+      window.removeEventListener("keydown", handleEsc);
+    };
+  }, [isOpen, onClose]);
+
+  // Early return AFTER all hooks
+  // Only return null if contributor is missing (not if isOpen is false, to allow exit animations)
+  if (!contributor) return null;
+
   const formatDate = (dateString: string) => {
     const date = new Date(dateString);
     return date.toLocaleDateString("en-US", {
@@ -93,21 +111,6 @@ export default function PRListModal({
     return "#6b7280"; // Gray for no points
   };
 
-  // Close modal on Escape key press
-  useEffect(() => {
-    if (!isOpen) return;
-    const handleEsc = (event: KeyboardEvent) => {
-      if (event.key === "Escape") {
-        onClose();
-      }
-    };
-
-    window.addEventListener("keydown", handleEsc);
-    return () => {
-      window.removeEventListener("keydown", handleEsc);
-    };
-  }, [isOpen, onClose]);
-
   return (
     <AnimatePresence>
       {isOpen && (