chore: copilot comments

django-oauth#1252 (review)

Author: dopry

oauth2_provider/oauth2_validators.py

@@ -159,7 +159,7 @@ def _authenticate_basic_auth(self, request):
         try:
             client_id, client_secret = map(unquote_plus, auth_string_decoded.split(":", 1))
         except ValueError:
-            log.debug("Failed basic auth, Invalid base64 encoding.")
+            log.debug("Failed basic auth, Invalid base64 encoding")
             return False
 
         if self._load_application(client_id, request) is None:
@@ -217,16 +217,16 @@ def _load_application(self, client_id, request):
         if request.client:
             # check for cached client, to save the db hit if this has already been loaded
             if not isinstance(request.client, Application):
-                log.debug("request.client is not an Application, something else set request.client erroneously, resetting request.client.")
+                log.debug("request.client is not an Application, something else set request.client erroneously, resetting request.client")
                 request.client = None
             elif request.client.client_id != client_id:
-                log.debug("request.client client_id does not match the given client_id, resetting request.client.")
+                log.debug("request.client client_id does not match the given client_id, resetting request.client")
                 request.client = None
             elif not request.client.is_usable(request):
-                log.debug("request.client is a valid Application, but is not usable, resetting request.client.")
+                log.debug("request.client is a valid Application, but is not usable, resetting request.client")
                 request.client = None
             else:
-                log.debug("request.client is a valid Application, reusing it.")
+                log.debug("request.client is a valid Application, reusing it")
                 return request.client
         try:
             # cache wasn't hit, load from db
@@ -235,8 +235,8 @@ def _load_application(self, client_id, request):
             if not client.is_usable(request):
                 log.debug("Failed to load application: Application %r is not usable" % (client_id))
                 return None
-            log.debug("Loaded application %r from database", client)
             request.client = client
+            log.debug("Loaded application %r from database", client)
             return request.client
         except Application.DoesNotExist:
             log.debug("Failed to load application: Application %r does not exist" % (client_id))

tests/test_authorization_code.py

@@ -1310,7 +1310,7 @@ def test_request_body_params(self):
 
     def test_request_body_params_client_typo(self):
         """
-        Request an access token using client_type: public
+        Verify that using incorrect parameter name (client instead of client_id) returns invalid_client error
         """
         self.client.login(username="test_user", password="123456")
         authorization_code = self.get_auth()