Skip to content

Commit 17c63d3

Browse files
christophpurrermeta-codesync[bot]
authored andcommitted
Delete deprecated RCTBridge initializers (#59434)
Summary: Pull Request resolved: #59434 Both `RCTBridge` initializers return an inert stub and have no callers left now that the test harness is gone. Delete the declarations and stub implementations. `RCTBridgeModuleListProvider` stays until the proxy shim using it is removed. Changelog: [iOS][Removed] - Remove deprecated `RCTBridge` initializers Reviewed By: andrewdacenko Differential Revision: D127294773
1 parent dd7f53d commit 17c63d3

6 files changed

Lines changed: 0 additions & 48 deletions

File tree

‎packages/react-native/React/Base/RCTBridge.h‎

Lines changed: 0 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -84,34 +84,6 @@ RCT_EXTERN_C_END
8484
*/
8585
@interface RCTBridge : NSObject <RCTInvalidating>
8686

87-
/**
88-
* Creates a new bridge with a custom RCTBridgeDelegate.
89-
*
90-
* All the interaction with the JavaScript context should be done using the bridge
91-
* instance of the RCTBridgeModules. Modules will be automatically instantiated
92-
* using the default constructor, but you can optionally pass in an array of
93-
* pre-initialized module instances if they require additional init parameters
94-
* or configuration.
95-
*/
96-
- (instancetype)initWithDelegate:(id<RCTBridgeDelegate>)delegate
97-
launchOptions:(NSDictionary *)launchOptions
98-
__deprecated_msg("This API will be removed along with the legacy architecture.");
99-
100-
/**
101-
* DEPRECATED: Use initWithDelegate:launchOptions: instead
102-
*
103-
* The designated initializer. This creates a new bridge on top of the specified
104-
* executor. The bridge should then be used for all subsequent communication
105-
* with the JavaScript code running in the executor. Modules will be automatically
106-
* instantiated using the default constructor, but you can optionally pass in an
107-
* array of pre-initialized module instances if they require additional init
108-
* parameters or configuration.
109-
*/
110-
- (instancetype)initWithBundleURL:(NSURL *)bundleURL
111-
moduleProvider:(RCTBridgeModuleListProvider)block
112-
launchOptions:(NSDictionary *)launchOptions
113-
__deprecated_msg("This API will be removed along with the legacy architecture.");
114-
11587
/**
11688
* This method registers the file path of an additional JS segment by its ID.
11789
*

‎packages/react-native/React/Base/RCTBridge.mm‎

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -219,18 +219,6 @@ void RCTSetTurboModuleInteropBridgeProxyLogLevel(RCTBridgeProxyLoggingLevel logL
219219
}
220220

221221
@implementation RCTBridge
222-
- (instancetype)initWithDelegate:(id<RCTBridgeDelegate>)delegate launchOptions:(NSDictionary *)launchOptions
223-
{
224-
return self;
225-
}
226-
227-
- (instancetype)initWithBundleURL:(NSURL *)bundleURL
228-
moduleProvider:(__strong RCTBridgeModuleListProvider)block
229-
launchOptions:(NSDictionary *)launchOptions
230-
{
231-
return self;
232-
}
233-
234222
- (void)registerSegmentWithId:(NSUInteger)segmentId path:(NSString *)path
235223
{
236224
}

‎scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -660,8 +660,6 @@ interface RCTBridge : public NSObject <RCTInvalidating> {
660660
public virtual id moduleForClass:(Class moduleClass);
661661
public virtual id moduleForName:(NSString* moduleName);
662662
public virtual id moduleForName:lazilyLoadIfNecessary:(NSString* moduleName, BOOL lazilyLoad);
663-
public virtual instancetype initWithBundleURL:moduleProvider:launchOptions:(NSURL* bundleURL, RCTBridgeModuleListProvider block, NSDictionary* launchOptions);
664-
public virtual instancetype initWithDelegate:launchOptions:(id<RCTBridgeDelegate> delegate, NSDictionary* launchOptions);
665663
public virtual void onFastRefresh();
666664
public virtual void registerSegmentWithId:path:(NSUInteger segmentId, NSString* path);
667665
public virtual void setRCTTurboModuleRegistry:(id<RCTTurboModuleRegistry> turboModuleRegistry);

‎scripts/cxx-api/api-snapshots/ReactAppleFrameworksCxx.api‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -669,8 +669,6 @@ interface RCTBridge : public NSObject <RCTInvalidating> {
669669
public virtual id moduleForClass:(Class moduleClass);
670670
public virtual id moduleForName:(NSString* moduleName);
671671
public virtual id moduleForName:lazilyLoadIfNecessary:(NSString* moduleName, BOOL lazilyLoad);
672-
public virtual instancetype initWithBundleURL:moduleProvider:launchOptions:(NSURL* bundleURL, RCTBridgeModuleListProvider block, NSDictionary* launchOptions);
673-
public virtual instancetype initWithDelegate:launchOptions:(id<RCTBridgeDelegate> delegate, NSDictionary* launchOptions);
674672
public virtual void onFastRefresh();
675673
public virtual void registerSegmentWithId:path:(NSUInteger segmentId, NSString* path);
676674
public virtual void setRCTTurboModuleRegistry:(id<RCTTurboModuleRegistry> turboModuleRegistry);

‎scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -660,8 +660,6 @@ interface RCTBridge : public NSObject <RCTInvalidating> {
660660
public virtual id moduleForClass:(Class moduleClass);
661661
public virtual id moduleForName:(NSString* moduleName);
662662
public virtual id moduleForName:lazilyLoadIfNecessary:(NSString* moduleName, BOOL lazilyLoad);
663-
public virtual instancetype initWithBundleURL:moduleProvider:launchOptions:(NSURL* bundleURL, RCTBridgeModuleListProvider block, NSDictionary* launchOptions);
664-
public virtual instancetype initWithDelegate:launchOptions:(id<RCTBridgeDelegate> delegate, NSDictionary* launchOptions);
665663
public virtual void onFastRefresh();
666664
public virtual void registerSegmentWithId:path:(NSUInteger segmentId, NSString* path);
667665
public virtual void setRCTTurboModuleRegistry:(id<RCTTurboModuleRegistry> turboModuleRegistry);

‎scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -660,8 +660,6 @@ interface RCTBridge : public NSObject <RCTInvalidating> {
660660
public virtual id moduleForClass:(Class moduleClass);
661661
public virtual id moduleForName:(NSString* moduleName);
662662
public virtual id moduleForName:lazilyLoadIfNecessary:(NSString* moduleName, BOOL lazilyLoad);
663-
public virtual instancetype initWithBundleURL:moduleProvider:launchOptions:(NSURL* bundleURL, RCTBridgeModuleListProvider block, NSDictionary* launchOptions);
664-
public virtual instancetype initWithDelegate:launchOptions:(id<RCTBridgeDelegate> delegate, NSDictionary* launchOptions);
665663
public virtual void onFastRefresh();
666664
public virtual void registerSegmentWithId:path:(NSUInteger segmentId, NSString* path);
667665
public virtual void setRCTTurboModuleRegistry:(id<RCTTurboModuleRegistry> turboModuleRegistry);

0 commit comments

Comments
 (0)