From e7508910a0e4e52c20014b0198da73c682a2299c Mon Sep 17 00:00:00 2001 From: rvenky125 Date: Thu, 31 Oct 2024 13:46:48 +0530 Subject: [PATCH 1/2] added accessibility id as a locator --- js/SegmentedControlTab.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/js/SegmentedControlTab.js b/js/SegmentedControlTab.js index db2ca25..649d638 100644 --- a/js/SegmentedControlTab.js +++ b/js/SegmentedControlTab.js @@ -13,6 +13,7 @@ import { TouchableOpacity, View, useColorScheme, + Platform } from 'react-native'; import type {FontStyle, ViewStyle} from './types'; @@ -95,7 +96,9 @@ export const SegmentedControlTab = ({ accessibilityHint={accessibilityHint} accessibilityRole="button" accessibilityState={{selected: selected, disabled: !enabled}} - testID={testID}> + testID={testID} + accessible={true} + accessibilityLabel={Platform.select({android: testID, ios: value == 'string' ? value : testID})}> {typeof value === 'number' || typeof value === 'object' ? ( From 3e44ee5b2f6951ea5f00afdc510b5974ced4cd71 Mon Sep 17 00:00:00 2001 From: rvenky125 Date: Thu, 31 Oct 2024 16:51:00 +0530 Subject: [PATCH 2/2] addressed lint checks --- js/SegmentedControlTab.js | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/js/SegmentedControlTab.js b/js/SegmentedControlTab.js index 649d638..2469b8a 100644 --- a/js/SegmentedControlTab.js +++ b/js/SegmentedControlTab.js @@ -13,7 +13,7 @@ import { TouchableOpacity, View, useColorScheme, - Platform + Platform, } from 'react-native'; import type {FontStyle, ViewStyle} from './types'; @@ -97,8 +97,11 @@ export const SegmentedControlTab = ({ accessibilityRole="button" accessibilityState={{selected: selected, disabled: !enabled}} testID={testID} - accessible={true} - accessibilityLabel={Platform.select({android: testID, ios: value == 'string' ? value : testID})}> + accessible={true} + accessibilityLabel={Platform.select({ + android: testID, + ios: typeof value === 'string' ? value : testID, + })}> {typeof value === 'number' || typeof value === 'object' ? (