Merge pull request #18 from rbalet/patch-2

use HttpBackend instead of HttpClient

Author: denniske

notes.txt renamed to CONTRIBUTING.md

@@ -1,15 +1,6 @@
-
-
-
 npm i
 npx tsc && npm publish --access=public
 
-
-
-
-
-
-
 npx nx serve example --port 4300
 npx nx serve demo --port 4301
 

README.md

@@ -1,16 +1,21 @@
 # @ngx-translate/multi-http-loader [![npm version](https://badge.fury.io/js/ngx-translate-multi-http-loader.svg)](https://badge.fury.io/js/ngx-translate-multi-http-loader)
 
-A loader for [ngx-translate](https://github.com/ngx-translate/core) that loads translations using http.
 
-Angular 6 example: https://stackblitz.com/edit/ngx-translate-multi-http-loader-sample
+A loader for [ngx-translate](https://github.com/ngx-translate/core) that loads translations using http.
 
 Angular 13 example: https://github.com/denniske/ngx-translate-multi-http-loader-demo
 
+Angular 6 example: https://stackblitz.com/edit/ngx-translate-multi-http-loader-sample
+
 Get the complete changelog here: https://github.com/denniske/ngx-translate-multi-http-loader/releases
 
 * [Installation](#installation)
 * [Usage](#usage)
 
+## breaking change: v9.0.0
+* This library is now using `httpBackend` instead of the `httpClient`, to avoid being delayed by interceptor, which was creating errors while loading.
+* From the v9, the library will only be using a list of `string[]` so `prefix` & `suffix` aren't needed anymore and `.json` gonna be the default suffix.
+
 ## Installation
 
 We assume that you already installed [ngx-translate](https://github.com/ngx-translate/core).
@@ -23,32 +28,29 @@ npm install ngx-translate-multi-http-loader --save
 
 Choose the version corresponding to your Angular version:
 
- Angular     | @ngx-translate/core | ngx-translate-multi-http-loader
- ----------- |---------------------| --------------------------
- 14          | 14.x+               | 8.x+
- 13          | 14.x+               | 7.x+
- 6           | 10.x+               | 1.x+
+ | Angular | @ngx-translate/core | ngx-translate-multi-http-loader |
+ | ------- | ------------------- | ------------------------------- |
+ | 14      | 14.x+               | 8.x+                            |
+ | 13      | 14.x+               | 7.x+                            |
+ | 6       | 10.x+               | 1.x+                            |
 
 ## Usage
-#### 1. Setup the `TranslateModule` to use the `MultiTranslateHttpLoader`:
+_The `MultiTranslateHttpLoader` uses HttpBackend to load translations, therefore :_
+1. Create and export a new `HttpLoaderFactory` function
+2. Import the `HttpClientModule` from `@angular/common/http` 
+3. Setup the `TranslateModule` to use the `MultiTranslateHttpLoader`
 
-The `MultiTranslateHttpLoader` uses HttpClient to load translations, which means that you have to import the HttpClientModule from `@angular/common/http` before the `TranslateModule`:
-
-
-```ts
+```typescript
 import {NgModule} from '@angular/core';
 import {BrowserModule} from '@angular/platform-browser';
-import {HttpClientModule, HttpClient} from '@angular/common/http';
+import {HttpClientModule, HttpBackend} from '@angular/common/http';
 import {TranslateModule, TranslateLoader} from '@ngx-translate/core';
-import {MultiTranslateHttpLoader} from "ngx-translate-multi-http-loader";
-import {AppComponent} from "./app";
+import {MultiTranslateHttpLoader} from 'ngx-translate-multi-http-loader';
+import {AppComponent} from './app';
 
 // AoT requires an exported function for factories
-export function HttpLoaderFactory(http: HttpClient) {
-    return new MultiTranslateHttpLoader(http, [
-        {prefix: "./assets/translate/core/", suffix: ".json"},
-        {prefix: "./assets/translate/shared/", suffix: ".json"},
-    ]);
+export function HttpLoaderFactory(_httpBackend: HttpBackend) {
+    return new MultiTranslateHttpLoader(_httpBackend, ['/assets/i18n/core/', '/assets/i18n/vendors/']);
 }
 
 @NgModule({
@@ -59,7 +61,7 @@ export function HttpLoaderFactory(http: HttpClient) {
             loader: {
                 provide: TranslateLoader,
                 useFactory: HttpLoaderFactory,
-                deps: [HttpClient]
+                deps: [HttpBackend]
             }
         })
     ],
@@ -68,23 +70,10 @@ export function HttpLoaderFactory(http: HttpClient) {
 export class AppModule { }
 ```
 
-The `MultiTranslateHttpLoader` takes a list of translation file configurations. Each configuration has two optional parameters:
-- prefix: string = "/assets/translate/"
-- suffix: string = ".json"
-
-By using those default parameters, it will load your translations files for the lang "en" from: `/assets/translate/en.json`.
+The `MultiTranslateHttpLoader` takes a list of strings. 
 
-You can change those in the `HttpLoaderFactory` method that we just defined. For example if you want to load the "en" translations from `/assets/translate/core/en.json` and `/assets/translate/shared/en.json` you would use:
-
-```ts
-export function HttpLoaderFactory(http: HttpClient) {
-    return new MultiTranslateHttpLoader(http, [
-        {prefix: "./assets/translate/core/", suffix: ".json"},
-        {prefix: "./assets/translate/shared/", suffix: ".json"},
-    ]);
-}
-```
+Those strings, for example `['/assets/i18n/core/', '/assets/i18n/vendors/']`,   
+will load your translations files for the lang "en" from : `/assets/i18n/core/en.json` and `/assets/i18n/vendors/en.json`
 
-For now this loader only support the json format.
 
 The loader will merge all translation files from the server using [deepmerge](https://github.com/KyleAMathews/deepmerge).

package-lock.json

@@ -1,24 +1,26 @@
 {
   "name": "ngx-translate-multi-http-loader",
-  "version": "8.0.1",
+  "version": "9.0.0",
   "license": "MIT",
   "maintainers": [
     "denniske.npm@gmail.com"
   ],
-  "peerDependencies": {
-    "@angular/common": "^14.0.0",
-    "@angular/core": "^14.0.0"
+  "scripts": {
+    "serve:example": "npx nx serve example --port 4300",
+    "serve:demo": "npx nx serve demo --port 4301"
   },
-  "dependencies": {
+  "peerDependencies": {
     "@angular/common": ">=14.0.0",
     "@angular/core": ">=14.0.0",
     "@ngx-translate/core": ">=14.0.0",
     "deepmerge": ">=4.2.2",
-    "rxjs": ">=7.4.0",
-    "tslib": ">=2.0.0"
+    "rxjs": "7.5.7"
+  },
+  "dependencies": {
+    "tslib": "2.4.0"
   },
   "devDependencies": {
-    "typescript": ">=4.4.3"
+    "typescript": "4.8.4"
   },
   "main": "dist/multi-http-loader.js",
   "types": "dist/multi-http-loader.d.ts",