From 9c159adb44577943a15c6d5aaf1eb82fbee5a784 Mon Sep 17 00:00:00 2001 From: paanSinghCoder Date: Wed, 11 Mar 2026 12:43:16 +0530 Subject: [PATCH 1/4] fix (breadcrumb): ref not forwarded for trigger --- packages/raystack/components/breadcrumb/breadcrumb-item.tsx | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/raystack/components/breadcrumb/breadcrumb-item.tsx b/packages/raystack/components/breadcrumb/breadcrumb-item.tsx index 0b3471ac2..a911d7a0a 100644 --- a/packages/raystack/components/breadcrumb/breadcrumb-item.tsx +++ b/packages/raystack/components/breadcrumb/breadcrumb-item.tsx @@ -55,7 +55,10 @@ export const BreadcrumbItem = forwardRef< if (dropdownItems) { return ( - + } + className={styles['breadcrumb-dropdown-trigger']} + > {label} From c6e92778c6b85884940546f000837f9e57d9f304 Mon Sep 17 00:00:00 2001 From: paanSinghCoder Date: Wed, 11 Mar 2026 16:02:24 +0530 Subject: [PATCH 2/4] fix (breadcrumb): forward props to trigger --- .../raystack/components/breadcrumb/breadcrumb-item.tsx | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/packages/raystack/components/breadcrumb/breadcrumb-item.tsx b/packages/raystack/components/breadcrumb/breadcrumb-item.tsx index a911d7a0a..fb63bff80 100644 --- a/packages/raystack/components/breadcrumb/breadcrumb-item.tsx +++ b/packages/raystack/components/breadcrumb/breadcrumb-item.tsx @@ -57,7 +57,12 @@ export const BreadcrumbItem = forwardRef< } - className={styles['breadcrumb-dropdown-trigger']} + className={cx(styles['breadcrumb-dropdown-trigger'], className)} + id={props.id} + title={props.title} + aria-label={props['aria-label']} + aria-labelledby={props['aria-labelledby']} + aria-describedby={props['aria-describedby']} > {label} From 7df155f4b325b195cb4ba18d1cd47d7dd71313ed Mon Sep 17 00:00:00 2001 From: paanSinghCoder Date: Thu, 12 Mar 2026 14:16:39 +0530 Subject: [PATCH 3/4] fix: spread porps --- packages/raystack/components/breadcrumb/breadcrumb-item.tsx | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/packages/raystack/components/breadcrumb/breadcrumb-item.tsx b/packages/raystack/components/breadcrumb/breadcrumb-item.tsx index fb63bff80..a4c91af43 100644 --- a/packages/raystack/components/breadcrumb/breadcrumb-item.tsx +++ b/packages/raystack/components/breadcrumb/breadcrumb-item.tsx @@ -58,11 +58,7 @@ export const BreadcrumbItem = forwardRef< } className={cx(styles['breadcrumb-dropdown-trigger'], className)} - id={props.id} - title={props.title} - aria-label={props['aria-label']} - aria-labelledby={props['aria-labelledby']} - aria-describedby={props['aria-describedby']} + {...(props as React.ButtonHTMLAttributes)} > {label} From 3434653f0aed1abe7cc7a9e52bb6779293950783 Mon Sep 17 00:00:00 2001 From: paanSinghCoder Date: Fri, 20 Mar 2026 15:35:45 +0530 Subject: [PATCH 4/4] chore: pass only apt props --- .../src/content/docs/components/navbar/demo.css | 2 +- .../components/breadcrumb/breadcrumb-item.tsx | 14 +++++++++++++- .../raystack/components/navbar/navbar.module.css | 2 +- 3 files changed, 15 insertions(+), 3 deletions(-) diff --git a/apps/www/src/content/docs/components/navbar/demo.css b/apps/www/src/content/docs/components/navbar/demo.css index 5562ae167..97716a237 100644 --- a/apps/www/src/content/docs/components/navbar/demo.css +++ b/apps/www/src/content/docs/components/navbar/demo.css @@ -3,4 +3,4 @@ flex-direction: column; align-items: flex-start; width: 100%; -} \ No newline at end of file +} diff --git a/packages/raystack/components/breadcrumb/breadcrumb-item.tsx b/packages/raystack/components/breadcrumb/breadcrumb-item.tsx index a8ae669c9..7a993b0c9 100644 --- a/packages/raystack/components/breadcrumb/breadcrumb-item.tsx +++ b/packages/raystack/components/breadcrumb/breadcrumb-item.tsx @@ -35,6 +35,14 @@ export const BreadcrumbItem = ({ dropdownItems, ...props }: BreadcrumbItemProps) => { + const { + id, + title, + 'aria-label': ariaLabel, + 'aria-labelledby': ariaLabelledby, + 'aria-describedby': ariaDescribedby + } = props; + const renderedElement = as ?? ; const label = ( <> @@ -52,7 +60,11 @@ export const BreadcrumbItem = ({ } className={styles['breadcrumb-dropdown-trigger']} - {...(props as React.ButtonHTMLAttributes)} + id={id} + title={title} + aria-label={ariaLabel} + aria-labelledby={ariaLabelledby} + aria-describedby={ariaDescribedby} > {label} diff --git a/packages/raystack/components/navbar/navbar.module.css b/packages/raystack/components/navbar/navbar.module.css index 1dac86d82..bd9ecc739 100644 --- a/packages/raystack/components/navbar/navbar.module.css +++ b/packages/raystack/components/navbar/navbar.module.css @@ -41,4 +41,4 @@ .end { grid-column: 3; justify-self: end; -} \ No newline at end of file +}