RDBC-644 RavenDB_15706Test::bulkInsertWithoutDB

Author: poissoncorp

ravendb/documents/store/definition.py

@@ -291,19 +291,19 @@ def get_effective_database_static(store: DocumentStoreBase, database: str) -> st
         if database is None:
             database = store.database
 
-        if not database.isspace():
+        if database and not database.isspace():
             return database
 
         raise ValueError(
             "Cannot determine database to operate on. "
             "Please either specify 'database' directly as an action parameter "
-            "or set the default database to operate on using 'DocumentStore.setDatabase' method. "
+            "or set the default database to operate on using 'DocumentStore.database'. "
             "Did you forget to pass 'database' parameter?"
         )
 
 
 class DocumentStore(DocumentStoreBase):
-    def __init__(self, urls: Optional[Union[str, List[str]]] = None, database: Optional[str] = None):
+    def __init__(self, urls: Union[str, List[str]] = None, database: Optional[str] = None):
         super(DocumentStore, self).__init__()
         self.__subscriptions = DocumentSubscriptions(self)
         self.__thread_pool_executor = ThreadPoolExecutor()

ravendb/tests/jvm_migrated_tests/issues_tests/test_ravenDB_15706.py

@@ -0,0 +1,13 @@
+from ravendb import DocumentStore
+from ravendb.tests.test_base import TestBase
+
+
+class TestRavenDB15706(TestBase):
+    def setUp(self):
+        super(TestRavenDB15706, self).setUp()
+
+    def test_bulk_insert_without_db(self):
+        with DocumentStore(self.store.urls) as store:
+            store.initialize()
+            with self.assertRaises(ValueError):
+                store.bulk_insert()