RDBC-685 SessionCountersTest::sessionIncludeAllCountersAfterIncludeSingleCounterShouldThrow

Author: poissoncorp

ravendb/documents/session/loaders/include.py

@@ -69,7 +69,7 @@ def _include_all_counters(self, source_path: str):
             self._counters_to_include_by_source_path = CaseInsensitiveDict()
         val = self._counters_to_include_by_source_path.get(source_path)
         if val is not None and val[1] is not None:
-            raise ValueError("You cannot use all_counters() after using counters(*names)")
+            raise RuntimeError("You cannot use all_counters() after using counters(*names)")
         self._counters_to_include_by_source_path[source_path] = (True, None)
 
     def _assert_not_all_and_add_new_entry_if_needed(self, path: str):

ravendb/tests/jvm_migrated_tests/client_tests/counters_tests/test_session_counters.py

@@ -741,3 +741,20 @@ def test_session_include_single_counter(self):
             self.assertEqual(100, counter)
 
             self.assertEqual(1, session.advanced.number_of_requests)
+
+    def test_session_include_all_counters_after_include_single_counter_should_throw(self):
+        with self.store.open_session() as session:
+            session.store(Company(name="HR"), "companies/1-A")
+            session.store(Order(company="companies/1-A"), "orders/1-A")
+            session.counters_for("orders/1-A").increment("likes", 100)
+            session.counters_for("orders/1-A").increment("dislikes", 200)
+            session.counters_for("orders/1-A").increment("downloads", 300)
+            session.save_changes()
+
+        with self.store.open_session() as session:
+            with self.assertRaises(RuntimeError):
+                session.load(
+                    "orders/1-A",
+                    Order,
+                    lambda i: i.include_documents("company").include_counter("likes").include_all_counters(),
+                )