Skip to content

Commit d51b292

Browse files
committed
RDBC-694 Stop the deluge of unclosed socket warnings while running tests
1 parent cd07251 commit d51b292

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

ravendb/http/request_executor.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -128,6 +128,7 @@ def close(self):
128128
self.__update_topology_timer.cancel()
129129

130130
self._dispose_all_failed_nodes_timers()
131+
self.__http_session.close()
131132

132133
@property
133134
def certificate_path(self) -> str:

ravendb/serverwide/server_operation_executor.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,8 @@ def __init__(self, store: DocumentStore):
4141
self.__node_tag = None
4242
self.__cache = CaseInsensitiveDict()
4343

44-
# todo: register events
45-
46-
# todo: if node tag is null add after_close_listener
44+
store.register_events_for_request_executor(self.__request_executor)
45+
store.add_after_close(self.close)
4746

4847
def send(self, operation: ServerOperation[_T_OperationResult]) -> Optional[None, _T_OperationResult]:
4948
command = operation.get_command(self.__request_executor.conventions)

0 commit comments

Comments
 (0)