Issue-198 Unable to create documents with server generated UUID's

Author: poissoncorp

ravendb/documents/session/document_session_operations/in_memory_document_session_operations.py

@@ -710,7 +710,7 @@ def increment_requests_count(self) -> None:
             )
 
     def _assert_no_non_unique_instance(self, entity: object, key: str) -> None:
-        if (not key) or key[-1] == "|" or key[-1] == self.conventions.identity_parts_separator:
+        if not key or key[-1] == "|" or key[-1] == self.conventions.identity_parts_separator:
             return
 
         info = self._documents_by_id.get(key)
@@ -931,7 +931,7 @@ def _store_entity_in_unit_of_work(
             document=None,
         )
         self._documents_by_entity[entity] = document_info
-        if key:
+        if key is not None:
             self._documents_by_id[key] = document_info
 
     def prepare_for_save_changes(self) -> SaveChangesData:
@@ -1882,7 +1882,8 @@ def update_entity_document_info(self, document_info: DocumentInfo, document: dic
 
             def clear_session_state_after_successful_save_changes(self):
                 for key in self.__documents_by_id_to_remove:
-                    self.__session._documents_by_id.pop(key)
+                    if key in self.__session.documents_by_id:
+                        self.__session._documents_by_id.pop(key)
                 for key in self.__documents_by_entity_to_remove:
                     self.__session._documents_by_entity.pop(key)
 

ravendb/tests/issue_tests/test_issue_198.py

@@ -0,0 +1,47 @@
+from ravendb.tests.test_base import TestBase
+
+
+class Product:
+    def __init__(self, name: str = None):
+        self.name = name
+        self.Id = ""
+
+
+class TestIssue198(TestBase):
+    def setUp(self):
+        super().setUp()
+
+    def test_create_document_with_server_generated_guid(self):
+        guid_from_server = None
+        with self.store.open_session() as session:
+            product = Product("Test")
+            session.store(product)
+            session.save_changes()
+            guid_from_server = product.Id
+
+        with self.store.open_session() as session:
+            product = session.load(guid_from_server)
+            self.assertEqual("Test", product.name)
+
+    def test_can_create_multiple_documents_with_server_generated_guid(self):
+        with self.store.open_session() as session:
+            product1 = Product("Test1")
+            product2 = Product("Test2")
+            product3 = Product("Test3")
+            session.store(product1)
+            session.store(product2)
+            session.store(product3)
+            session.save_changes()
+            guid_from_server1 = product1.Id
+            guid_from_server2 = product2.Id
+            guid_from_server3 = product3.Id
+
+        with self.store.open_session() as session:
+            product1 = session.load(guid_from_server1)
+            self.assertEqual("Test1", product1.name)
+
+            product2 = session.load(guid_from_server2)
+            self.assertEqual("Test2", product2.name)
+
+            product3 = session.load(guid_from_server3)
+            self.assertEqual("Test3", product3.name)