RDBC-767 Time Series AppendOperation perf

Author: poissoncorp

ravendb/documents/operations/time_series.py

@@ -2,7 +2,7 @@
 
 import datetime
 import json
-from typing import Dict, Optional, List, Any, TYPE_CHECKING, Callable
+from typing import Dict, Optional, List, Any, TYPE_CHECKING, Callable, Set
 import requests
 
 from ravendb.primitives.constants import int_max
@@ -357,6 +357,12 @@ def __init__(self, timestamp: datetime.datetime, values: List[float], tag: Optio
             self.values = values
             self.tag = tag
 
+        def __eq__(self, other):
+            return isinstance(other, TimeSeriesOperation.AppendOperation) and other.timestamp == self.timestamp
+
+        def __hash__(self):
+            return hash(self.timestamp)
+
         def to_json(self) -> Dict[str, Any]:
             json_dict = {
                 "Timestamp": Utils.datetime_to_string(self.timestamp),
@@ -382,7 +388,7 @@ def to_json(self) -> Dict[str, Any]:
 
     def __init__(self, name: Optional[str] = None):
         self.name = name
-        self._appends: List[TimeSeriesOperation.AppendOperation] = []
+        self._appends: Set[TimeSeriesOperation.AppendOperation] = set()
         self._deletes: List[TimeSeriesOperation.DeleteOperation] = []
 
     def to_json(self) -> Dict[str, Any]:
@@ -395,14 +401,13 @@ def to_json(self) -> Dict[str, Any]:
 
     def append(self, append_operation: AppendOperation) -> None:
         if self._appends is None:
-            self._appends = []  # todo: perf
-        filtered = self._appends
+            self._appends = set()
 
-        # if len(filtered) != 0:
-        #     # element with given timestamp already exists - remove and retry add operation
-        #     self._appends.remove(filtered.pop())
+        if append_operation in self._appends:
+            # __eq__ override lets us discard old one by passing new one due to the same timestamps
+            self._appends.discard(append_operation)
 
-        self._appends.append(append_operation)
+        self._appends.add(append_operation)
 
     def delete(self, delete_operation: DeleteOperation) -> None:
         if self._deletes is None:

ravendb/tests/operations_tests/test_time_series_operation.py

@@ -9,6 +9,7 @@
 import unittest
 
 from ravendb.tests.test_base import TestBase, User
+from ravendb.tools.raven_test_helper import RavenTestHelper
 
 
 class TestTimeSeriesOperations(TestBase):
@@ -83,6 +84,23 @@ def test_get_time_series_without_range(self):
         ts_range_result = self.store.operations.send(GetTimeSeriesOperation("users/1-A", self.ts_name))
         self.assertEqual(len(ts_range_result.entries), 3)
 
+    def test_appending_second_time_series_value_at_the_same_timestamp_will_replace_the_previous_value(self):
+        base_line = RavenTestHelper.utc_this_month()
+        with self.store.open_session() as session:
+            session.store(User("Gracjan"), "users/gracjan")
+            tsf = session.time_series_for("users/gracjan", "stonks")
+            tsf.append_single(base_line, 1)
+            tsf.append_single(base_line, 2)
+            tsf.append_single(base_line, 3)
+            session.save_changes()
+
+        with self.store.open_session() as session:
+            gracjan = session.load("users/gracjan", User)
+            ts = session.time_series_for_entity(gracjan, "stonks").get()
+            self.assertEqual(1, len(ts))
+            self.assertEqual(1, len(ts[0].values))
+            self.assertEqual(3, ts[0].values[0])
+
 
 if __name__ == "__main__":
     unittest.main()