RDBC-768 canModifyDictionaryWithPatch_Add

Author: poissoncorp

ravendb/documents/session/misc.py

@@ -21,6 +21,7 @@
 _T_Key = TypeVar("_T_Key")
 _T_Value = TypeVar("_T_Value")
 
+
 class TransactionMode(Enum):
     SINGLE_NODE = "single_node"
     CLUSTER_WIDE = "cluster_wide"
@@ -233,7 +234,7 @@ def _get_next_argument_name(self) -> str:
         self._arg_counter += 1
         return f"val_{self._arg_counter - 1}_{self._suffix}"
 
-    def put(self, key: _T_Key, value:_T_Value) -> JavaScriptMap[_T_Key, _T_Value]:
+    def put(self, key: _T_Key, value: _T_Value) -> JavaScriptMap[_T_Key, _T_Value]:
         argument_name = self._get_next_argument_name()
 
         self._script_lines.append(f"this.{self._path_to_map}.{key} = args.{argument_name};")

ravendb/tests/jvm_migrated_tests/issues_tests/test_ravenDB_13452.py

@@ -2,14 +2,36 @@
 
 from ravendb.tests.test_base import TestBase
 
+
 class Item:
     def __init__(self, values: Dict[str, str] = None):
         self.values = values
 
+
 class TestRavenDB13452(TestBase):
     def setUp(self):
         super().setUp()
 
+    def test_can_modify_dictionary_with_patch_add(self):
+        with self.store.open_session() as session:
+            item = Item({"Key1": "Value1", "Key2": "Value2"})
+            session.store(item, "items/1")
+            session.save_changes()
+
+        with self.store.open_session() as session:
+            item = session.load("items/1", Item)
+            session.advanced.patch_object(item, "values", lambda dict_: dict_.put("Key3", "Value3"))
+            session.save_changes()
+
+        with self.store.open_session() as session:
+            item = session.load("items/1", dict)
+            values = item.get("values", None)
+            self.assertIsNotNone(values)
+            self.assertEqual(3, len(values))
+            self.assertEqual("Value1", values.get("Key1"))
+            self.assertEqual("Value2", values.get("Key2"))
+            self.assertEqual("Value3", values.get("Key3"))
+
     def test_can_modify_dictionary_with_patch_remove(self):
         with self.store.open_session() as session:
             item = Item()
@@ -29,11 +51,9 @@ def test_can_modify_dictionary_with_patch_remove(self):
 
         with self.store.open_session() as session:
             item = session.load("items/1", dict)
-            values = item.get("values")
+            values = item.get("values", None)
             self.assertIsNotNone(values)
             self.assertEqual(2, len(values))
 
             self.assertEqual("Value1", values.get("Key1"))
             self.assertEqual("Value3", values.get("Key3"))
-
-