code cleanup

Author: gregolsky

src/Documents/Commands/Batches/BatchCommand.ts

@@ -89,21 +89,6 @@ export class BatchCommand extends RavenCommand<IRavenArrayResult> implements IDi
         }
 
         return request;
-        /* TBD: attachments - TODO: delete me?
-
-        if (_attachmentStreams != null && _attachmentStreams.Count > 0)
-        {
-            var multipartContent = new MultipartContent {request.Content};
-            foreach (var stream in _attachmentStreams)
-            {
-                PutAttachmentCommandHelper.PrepareStream(stream);
-                var streamContent = new AttachmentStreamContent(stream, CancellationToken);
-                streamContent.Headers.TryAddWithoutValidation("Command-Type", "AttachmentStream");
-                multipartContent.Add(streamContent);
-            }
-            request.Content = multipartContent;
-        }
-            */
     }
 
     public async setResponseAsync(bodyStream: stream.Stream, fromCache: boolean): Promise<string> {

src/Documents/Commands/MultiGet/GetRequest.ts

@@ -1,4 +1,3 @@
-//TODO: fill missing JSDocs?
 export class GetRequest {
     private _url: string;
     private _headers: { [key: string]: string | string[] };

src/Documents/Identity/IHiloIdGenerator.ts

@@ -1,7 +1,6 @@
 import { DocumentConventions } from "../Conventions/DocumentConventions";
 
 export interface IHiloIdGenerator {
-    //TODO ? nextId(...args: Array<object | string | string>): Promise<number>;
     generateDocumentId(...args: any[]): Promise<string>;
 
     returnUnusedRange(): Promise<void>;

src/Documents/Indexes/IndexDefinition.ts

@@ -26,7 +26,6 @@ export class IndexDefinition {
     public reduce: string;
     public fields: { [fieldName: string]: IndexFieldOptions } = {};
     public configuration: IndexConfiguration = {};
-    // TBD 4.1 private boolean testIndex;
     public outputReduceToCollection: string;
 
     //TODO: public toJSON() {
@@ -56,10 +55,6 @@ export class IndexDefinition {
         return "MapReduce";
     }
 
-    // TODO remove? TBD 4.1 public boolean isTestIndex()
-
-    // TODO remove? TBD 4.1 public void setTestIndex(boolean testIndex)
-
 }
 
 export class IndexDefinitionBuilder {

src/Documents/Session/DocumentQuery.ts

@@ -517,11 +517,6 @@ export class DocumentQuery<T extends object>
             query.on("afterQuery", listener as any);
         }
 
-        /* TODO AfterStreamExecutedCallback = AfterStreamExecutedCallback, should it be implemented?
-        for: 4.1: query.HighlightedFields = new List<HighlightedField>(HighlightedFields),
-        query.HighlighterPreTags = HighlighterPreTags,
-        query.HighlighterPostTags = HighlighterPostTags,
-        */
         query._disableEntitiesTracking = this._disableEntitiesTracking;
         query._disableCaching = this._disableCaching;
         // TBD ShowQueryTimings = ShowQueryTimings,

src/Documents/Session/EntityToJson.ts

@@ -36,7 +36,6 @@ export class EntityToJson {
             typeInfo = _typeInfo;
         }, conventions.knownEntityTypesByName);
 
-        // TODO handle Maps
         if (entity instanceof SetupDocumentBase) {
             jsonNode = entity.toRemoteFieldNames();
         } else {

src/Documents/Session/Operations/Lazy/IndexQueryContent.ts

@@ -85,7 +85,6 @@ export class SubscriptionBatch<T extends object> {
 
             if (!item.exception) {
                 instance = curDoc;
-                //TODO: make sure above assignment is correct when entities has custom casing
 
                 if (!StringUtil.isNullOrEmpty(id)) {
                     this._generateEntityIdOnTheClient.trySetIdentity(instance, id);

src/Documents/Subscriptions/SubscriptionBatch.ts

@@ -33,7 +33,7 @@ export class ObjectKeyCaseTransformStream extends stream.Transform {
     constructor(private _opts: ObjectKeyCaseTransformStreamOptions) {
         super({ objectMode: true });
 
-        this._opts = Object.assign({}, DEFAULT_OBJECT_KEY_CASE_TRANSFORM_OPTS, this._opts); //TODO:
+        this._opts = Object.assign({}, DEFAULT_OBJECT_KEY_CASE_TRANSFORM_OPTS, this._opts);
         ObjectKeyCaseTransformStream._validateOpts(_opts);
 
         if (typeof _opts.extractIgnorePaths === "function") {

src/Mapping/Json/Streams/ObjectKeyCaseTransformStream.ts

@@ -21,16 +21,6 @@ export class GetClusterTopologyCommand extends RavenCommand<ClusterTopologyRespo
         return { uri };
     }
 
-    public setResponse(response: string, fromCache: boolean): void { //TODO: do we need this method?
-        if (!response) {
-            this._throwInvalidResponse();
-        }
-
-        const resObj = this._serializer.deserialize<IRavenResponse>(response);
-        const clusterTpl = Object.assign(new ClusterTopology(), resObj.topology);
-        this.result = Object.assign(resObj as ClusterTopologyResponse, { topology: clusterTpl });
-    }
-
     public async setResponseAsync(bodyStream: stream.Stream, fromCache: boolean): Promise<string> {
         if (!bodyStream) {
             this._throwInvalidResponse();