add tests for RavenDB-12169

Author: gregolsky

src/Documents/Commands/Batches/BatchPatchCommandData.ts

@@ -22,7 +22,9 @@ export class BatchPatchCommandData implements ICommandData {
     private _patch: PatchRequest;
     private _patchIfMissing: PatchRequest;
 
-    private constructor(patch: PatchRequest, patchIfMissing: PatchRequest, ...ids: Array<string | IdAndChangeVector>) {
+    public constructor(patch: PatchRequest, patchIfMissing: PatchRequest, ...ids: string[]);
+    public constructor(patch: PatchRequest, patchIfMissing: PatchRequest, ...ids: IdAndChangeVector[]);
+    public constructor(patch: PatchRequest, patchIfMissing: PatchRequest, ...ids: Array<IdAndChangeVector | string>) {
         if (!patch) {
             throwError("InvalidArgumentException", "Patch cannot be null.");
         }

src/index.ts

@@ -204,6 +204,16 @@ export *  from "./Documents/Session/IMetadataDictionary";
 export *  from "./Documents/Session/DocumentResultStream";
 export * from "./Documents/Commands/StreamResult";
 export * from "./Documents/Session/SessionOptions";
+export * from "./Documents/Commands/CommandData";
+export * from "./Documents/Commands/Batches/CopyAttachmentCommandData";
+export * from "./Documents/Commands/Batches/DeleteAttachmentCommandData";
+export * from "./Documents/Commands/Batches/MoveAttachmentCommandData";
+export * from "./Documents/Commands/Batches/PutAttachmentCommandData";
+export * from "./Documents/Commands/Batches/BatchPatchCommandData";
+export * from "./Documents/Commands/Batches/CountersBatchCommandData";
+export * from "./Documents/Commands/Batches/PatchCommandData";
+export * from "./Documents/Commands/Batches/PutCompareExchangeCommandData";
+export * from "./Documents/Commands/Batches/DeleteCompareExchangeCommandData";
 
 // COUNTERS
 

test/Ported/Issues/RavenDB_12132.ts

@@ -11,7 +11,7 @@ import {
     SessionOptions,
 } from "../../../src";
 
-describe.only("RavenDB-12132", function () {
+describe("RavenDB-12132", function () {
 
     let store: IDocumentStore;
 

test/Ported/Issues/RavenDB_12169.ts

@@ -0,0 +1,114 @@
+import * as mocha from "mocha";
+import * as assert from "assert";
+import { User, Company, Order } from "../../Assets/Entities";
+import { assertThat, assertThrows } from "../../Utils/AssertExtensions";
+import { testContext, disposeTestDocumentStore } from "../../Utils/TestUtil";
+
+import {
+    RavenErrorType,
+    IDocumentStore,
+    BatchPatchCommandData,
+    PatchRequest,
+} from "../../../src";
+
+describe.only("RavenDB-12169", function () {
+
+    let store: IDocumentStore;
+
+    beforeEach(async function () {
+        testContext.enableFiddler();
+        store = await testContext.getDocumentStore();
+    });
+
+    afterEach(async () => 
+        await disposeTestDocumentStore(store));
+
+    it("canUseBatchPatchCommand", async () => {
+        {
+            const session = store.openSession();
+            await session.store(Object.assign(new Company(), { name: "C1" }), "companies/1");
+            await session.store(Object.assign(new Company(), { name: "C2" }), "companies/2");
+            await session.store(Object.assign(new Company(), { name: "C3" }), "companies/3");
+            await session.store(Object.assign(new Company(), { name: "C4" }), "companies/4");
+            await session.saveChanges();
+        }
+
+        {
+            const session = store.openSession();
+            
+            const c1 = await session.load<Company>("companies/1");
+            const c2 = await session.load<Company>("companies/2");
+            const c3 = await session.load<Company>("companies/3");
+            const c4 = await session.load<Company>("companies/4");
+
+            assertThat(c1.name)
+                .isEqualTo("C1");
+            assertThat(c2.name)
+                .isEqualTo("C2");
+            assertThat(c3.name)
+                .isEqualTo("C3");
+            assertThat(c4.name)
+                .isEqualTo("C4");
+
+            const ids = [ c1.id, c3.id ];
+
+            session.advanced.defer(
+                new BatchPatchCommandData(
+                    PatchRequest.forScript("this.name = 'test'; "), null, ...ids));
+
+            session.advanced.defer(
+                new BatchPatchCommandData(
+                    PatchRequest.forScript("this.name = 'test2'; "), null, c4.id));
+
+            await session.saveChanges();
+        }
+
+        {
+
+            const session = store.openSession();
+            const c1 = await session.load<Company>("companies/1");
+            const c2 = await session.load<Company>("companies/2");
+            const c3 = await session.load<Company>("companies/3");
+            const c4 = await session.load<Company>("companies/4");
+
+            assertThat(c1.name)
+                .isEqualTo("test");
+            assertThat(c2.name)
+                .isEqualTo("C2");
+            assertThat(c3.name)
+                .isEqualTo("test");
+            assertThat(c4.name)
+                .isEqualTo("test2");
+        }
+
+        {
+            const session = store.openSession();
+            const c2 = await session.load<Company>("companies/2");
+            
+            session.advanced.defer(
+                new BatchPatchCommandData(
+                    PatchRequest.forScript("this.name = 'test2'"), null, { id: c2.id,  changeVector: "invalidCV" }));
+
+            await assertThrows(async () => {
+                await session.saveChanges();
+            }, err => assert.strictEqual(err.name, "ConcurrencyException"));
+        }
+
+        {
+
+            const session = store.openSession();
+            const c1 = await session.load<Company>("companies/1");
+            const c2 = await session.load<Company>("companies/2");
+            const c3 = await session.load<Company>("companies/3");
+            const c4 = await session.load<Company>("companies/4");
+            assertThat(c1.name)
+                .isEqualTo("test");
+            assertThat(c2.name)
+                .isEqualTo("C2");
+            assertThat(c3.name)
+                .isEqualTo("test");
+            assertThat(c4.name)
+                .isEqualTo("test2");
+        }
+    });
+});