Merge pull request #155 from gregolsky/v4.0

update stream-json dep; use values only json parsers

Author: gregolsky

package-lock.json

@@ -83,7 +83,7 @@
     "request": "^2.88.0",
     "safe-memory-cache": "^1.5.1",
     "semaphore": "^1.1.0",
-    "stream-json": "^1.1.1",
+    "stream-json": "^1.1.3",
     "string-builder": "^0.1.6",
     "util.promisify": "^1.0.0",
     "uuid": "^3.2.1",

package.json

@@ -165,23 +165,7 @@ export class RavenCommandResponsePipeline<TStreamResult> extends EventEmitter {
         }
 
         if (opts.jsonAsync) {
-            const parser = new Parser({
-                packKeys: true,
-                packStrings: true,
-                packNumbers: true,
-                streamNumbers: true,
-                streamKeys: false,
-                streamStrings: false
-                // TODO perfect setup perf-wise below, reducing traffic by packing all values 
-                // not yet working due to issue uhop/stream-json#44 - stringer freezes
-                // we still need to stream numbers
-                // packKeys: true,
-                // packStrings: true,
-                // packNumbers: true,
-                // streamNumbers: false,
-                // streamKeys: false,
-                // streamStrings: false
-            });
+            const parser = new Parser({ streamValues: false });
             streams.push(parser);
 
             if (opts.jsonAsync.filters && opts.jsonAsync.filters.length) {

src/Http/RavenCommandResponsePipeline.ts

@@ -15,7 +15,7 @@ describe("stream-json parser and stringer", function () {
         readable.push(null);
 
         const parser = new Parser({
-            packKeys: true
+            streamValues: false 
         });
 
         let hasNumberChunk = false;
@@ -35,23 +35,15 @@ describe("stream-json parser and stringer", function () {
             });
     });
 
-    // TODO waiting for resolution of https://github.com/uhop/stream-json/issues/44
-    it.skip("parser with streamNumbers turned off should not emit 'numberChunk' tokens", (done) => {
+    it("parser with streamNumbers turned off should not emit 'numberChunk' tokens", (done) => {
 
         const content = `{ "test": -1 }`;
         const readable = new stream.Readable();
         readable.push(content);
         readable.push(null);
 
         const parser = new Parser({
-            packKeys: true,
-            packStrings: true,
-            packValues: true,
-            packNumbers: true,
-            streamNumbers: false,
-            streamValues: false,
-            streamKeys: false,
-            streamStrings: false
+            streamValues: false
         });
 
         let hasNumberChunk = false;
@@ -73,14 +65,7 @@ describe("stream-json parser and stringer", function () {
         readable.push(null);
 
         const parser = new Parser({
-            packKeys: true,
-            packStrings: true,
-            packValues: true,
-            packNumbers: true,
-            streamNumbers: true,
-            streamValues: false,
-            streamKeys: false,
-            streamStrings: false
+            streamValues: false
         });
 
         const stringerInstance = stringer({ useValues: true });