Merge pull request #167 from gregolsky/v4.0

send query params in utc

Author: gregolsky

src/Documents/Session/AbstractDocumentQuery.ts

@@ -389,7 +389,7 @@ export abstract class AbstractDocumentQuery<T extends object, TSelf extends Abst
 
     private _stringifyParameter(value: any) {
         if (TypeUtil.isDate(value)) {
-            return DateUtil.default.stringify(value);
+            return DateUtil.utc.stringify(value);
         }
 
         if (TypeUtil.isString(value)) {

src/Utility/DateUtil.ts

@@ -13,6 +13,8 @@ export class DateUtil {
 
     public static default: DateUtil = new DateUtil({});
 
+    public static utc: DateUtil = new DateUtil({ useUtcDates: true });
+
     public constructor(private _opts: DateUtilOpts) {}
 
     public static timestamp(): number {

test/Documents/Commands/DeleteDocumentCommandTest.ts

@@ -8,6 +8,9 @@ import {
 import { User } from "../../Assets/Entities";
 
 describe("DeleteDocumentCommand", function () {
+    
+    // it's the first test setting up the server
+    this.timeout(20000);
 
     let store: IDocumentStore;
 

test/Issues/RDBC_236.ts

@@ -12,7 +12,8 @@ import { DateUtil } from "../../src/Utility/DateUtil";
 import { GetDocumentsCommand } from "../../src/Documents/Commands/GetDocumentsCommand";
 import { StringUtil } from "../../src/Utility/StringUtil";
 
-const LOCAL_TIMEZONE_OFFSET = -(new Date().getTimezoneOffset()); // getTimezoneOffset() returns reversed offset
+// getTimezoneOffset() returns reversed offset
+const LOCAL_TIMEZONE_OFFSET = -(new Date(2018, 7, 1).getTimezoneOffset()); 
 const LOCAL_TIMEZONE_OFFSET_HOURS = LOCAL_TIMEZONE_OFFSET / 60;
 const LOCAL_TIMEZONE_STRING =
     // tslint:disable-next-line:max-line-length

test/Ported/Faceted/AggregationTest.ts

@@ -54,6 +54,9 @@ describe("AggregationTest", function () {
     let store: IDocumentStore;
 
     beforeEach(async function () {
+        testContext.customizeStore = async store => {
+            store.conventions.storeDatesInUtc = true;
+        };
         store = await testContext.getDocumentStore();
     });
 

test/Ported/QueryTest.ts

@@ -18,6 +18,9 @@ describe("QueryTest", function () {
     let store: IDocumentStore;
 
     beforeEach(async function () {
+        testContext.customizeStore = async store => {
+            store.conventions.storeDatesInUtc = true;
+        };
         store = await testContext.getDocumentStore();
     });
 
@@ -663,15 +666,15 @@ describe("QueryTest", function () {
     it("query where between with dates", async () => {
         const cocartFestival = new Event({
             name: "CoCArt Festival",
-            date: moment("2018-03-08").toDate()
+            date: moment("2018-03-08T00:00:00Z").toDate()
         });
         const openerFestival = new Event({
             name: "Open'er Festival",
-            date: moment("2018-07-04").toDate()
+            date: moment("2018-07-04T00:00:00Z").toDate()
         });
         const offFestival = new Event({
             name: "OFF Festival",
-            date: moment("2018-08-03").toDate()
+            date: moment("2018-08-03T00:00:00Z").toDate()
         });
 
         {
@@ -693,10 +696,10 @@ describe("QueryTest", function () {
             assert.strictEqual(indexQuery.query, "from events where date between $p0 and $p1");
             assert.strictEqual(
                 indexQuery.queryParameters["p0"], 
-                DateUtil.default.stringify(cocartFestival.date));
+                DateUtil.utc.stringify(cocartFestival.date));
             assert.strictEqual(
                 indexQuery.queryParameters["p1"], 
-                DateUtil.default.stringify(offFestival.date));
+                DateUtil.utc.stringify(offFestival.date));
             assert.strictEqual(indexQuery.query, "from events where date between $p0 and $p1");
 
             const festivalsHappeningBetweenCocartAndOffInclusive: any[] = await q.all();