Merge pull request #263 from ravendb/v4.2

 RDBC-442 NodeSelector bug

Author: gregolsky

package-lock.json

@@ -84,6 +84,7 @@
     "@types/node-fetch": "^2.5.7",
     "@types/qs": "^6.9.5",
     "@types/semaphore": "^1.1.0",
+    "@types/stream-json": "^1.5.1",
     "@types/uuid": "^8.3.0",
     "@types/verror": "^1.10.4",
     "abort-controller": "^3.0.0",

package.json

@@ -52,7 +52,7 @@ export class NodeSelector {
         }
 
         const stateEtag: number = this._state.topology.etag || 0;
-        const topologyEtag: number = this._state.topology.etag || 0;
+        const topologyEtag: number = topology.etag || 0;
 
         if (stateEtag >= topologyEtag && !forceUpdate) {
             return false;

src/Http/NodeSelector.ts

@@ -209,7 +209,7 @@ export class RavenCommandResponsePipeline<TStreamResult> extends EventEmitter {
         const opts = this._opts;
         let resultPromise: Promise<TStreamResult>;
         if (opts.jsonAsync) {
-            const asm = Asm.connectTo(streams[streams.length - 1]);
+            const asm = Asm.connectTo(streams[streams.length - 1] as any);
             resultPromise = new Promise(resolve => {
                 asm.on("done", asm => resolve(asm.current));
             });

src/Http/RavenCommandResponsePipeline.ts

@@ -11,7 +11,7 @@ export class TransformKeysJsonStream extends FilterBase {
     private _getTransform: (key: string, stack: (string | null | number)[]) => CasingConvention;
 
     constructor(opts: TransformJsonKeysStreamOptions) {
-        super();
+        super(null);
         opts = opts || { getCurrentTransform: (key, stack) => null };
         if (!opts.getCurrentTransform) {
             throwError("InvalidArgumentException", "getCurrentTransform() must not be empty.");
@@ -21,7 +21,7 @@ export class TransformKeysJsonStream extends FilterBase {
     }
 
     private _transformKey(key) {
-        const transformName = this._getTransform(key, this._stack);
+        const transformName = this._getTransform(key, (this as any)._stack); // HACK: access private field
         if (!transformName) {
             return key;
         }

src/Mapping/Json/Streams/TransformKeysJsonStream.ts

@@ -17,8 +17,7 @@
     ],
     "types": [
       "node",
-      "mocha",
-      "stream-json"
+      "mocha"
     ]
   },
   "files": [