fixing linter warnings

Author: ml054

src/Documents/Commands/MultiGet/MultiGetCommand.ts

@@ -238,7 +238,7 @@ export class MultiGetCommand extends RavenCommand<GetResponse[]> implements IDis
             // (include the IP and port of the old node), because of that the client
             // needs to get those docs again from the new node.
 
-            for (let command of this._commands) {
+            for (const command of this._commands) {
                 delete command.headers[HEADERS.IF_NONE_MATCH];
             }
         }

src/Documents/Identity/HiloIdGenerator.ts

@@ -51,7 +51,7 @@ export class HiloIdGenerator {
             // local range is not exhausted yet
             const range = this._range;
 
-            let id = range.increment();
+            const id = range.increment();
             if (id <= range.maxId) {
                 return id;
             }

src/Documents/Session/AbstractDocumentQuery.ts

@@ -2381,7 +2381,7 @@ export abstract class AbstractDocumentQuery<T extends object, TSelf extends Abst
             this._revisionsIncludesTokens = [];
         }
 
-        for (let changeVector of revisionsToIncludeByChangeVector) {
+        for (const changeVector of revisionsToIncludeByChangeVector) {
             this._revisionsIncludesTokens.push(RevisionIncludesToken.createForPath(changeVector));
         }
     }

src/Documents/Session/Tokens/WhereToken.ts

@@ -161,14 +161,17 @@ export class WhereToken extends QueryToken {
     }
 
     public writeTo(writer): void {
+        // tslint:disable-next-line:triple-equals
         if (this.options.boost != null) {
             writer.append("boost(");
         }
 
+        // tslint:disable-next-line:triple-equals
         if (this.options.fuzzy != null) {
             writer.append("fuzzy(");
         }
 
+        // tslint:disable-next-line:triple-equals
         if (this.options.proximity != null) {
             writer.append("proximity(");
         }
@@ -216,20 +219,23 @@ export class WhereToken extends QueryToken {
             writer.append(")");
         }
 
+        // tslint:disable-next-line:triple-equals
         if (this.options.proximity != null) {
             writer
                 .append(", ")
                 .append(this.options.proximity)
                 .append(")");
         }
 
+        // tslint:disable-next-line:triple-equals
         if (this.options.fuzzy != null) {
             writer
                 .append(", ")
                 .append(this.options.fuzzy)
                 .append(")");
         }
 
+        // tslint:disable-next-line:triple-equals
         if (this.options.boost != null) {
             writer
                 .append(", ")

src/Documents/Subscriptions/SubscriptionWorker.ts

@@ -315,7 +315,7 @@ export class SubscriptionWorker<T extends object> implements IDisposable {
         if (connectionStatus.type !== "ConnectionStatus") {
             let message = "Server returned illegal type message when expecting connection status, was:" + connectionStatus.type;
 
-            if (connectionStatus.type == "Error") {
+            if (connectionStatus.type === "Error") {
                 message += ". Exception: " + connectionStatus.exception;
             }
             throwError("InvalidOperationException", message);

src/Mapping/MetadataAsDictionary.ts

@@ -43,6 +43,7 @@ class MetadataInternal {
     }
 
     private _metadataConvertValue(key, val) {
+        // tslint:disable-next-line:triple-equals
         if (val == null) {
             return null;
         }

src/Utility/TcpUtils.ts

@@ -70,7 +70,7 @@ export class TcpUtils {
             for (const url of info.urls) {
                 try {
                     const socket = await this.connect(url, serverCertificate, clientCertificate);
-                    const supportedFeatures = await this.invokeNegotiation(info, operationType, negotiationCallback, url, socket);
+                    const supportedFeatures = await this._invokeNegotiation(info, operationType, negotiationCallback, url, socket);
                     return new ConnectSecuredTcpSocketResult(url, socket, supportedFeatures);
                 } catch {
                     // ignored
@@ -79,11 +79,11 @@ export class TcpUtils {
         }
 
         const socket = await this.connect(info.url, serverCertificate, clientCertificate);
-        const supportedFeatures = await this.invokeNegotiation(info, operationType, negotiationCallback, info.url, socket);
+        const supportedFeatures = await this._invokeNegotiation(info, operationType, negotiationCallback, info.url, socket);
         return new ConnectSecuredTcpSocketResult(info.url, socket, supportedFeatures);
     }
 
-    private static invokeNegotiation(info: TcpConnectionInfo, operationType: OperationTypes, negotiationCallback: NegotiationCallback, url: string, socket: Socket) {
+    private static _invokeNegotiation(info: TcpConnectionInfo, operationType: OperationTypes, negotiationCallback: NegotiationCallback, url: string, socket: Socket) {
         switch (operationType) {
             case "Subscription":
                 return negotiationCallback(url, info, socket);

test/Documents/Commands/PutDocumentCommandTests.ts

@@ -53,7 +53,7 @@ describe("PutDocumentCommand", function () {
         user.name = nameWithEmojis;
         user.age = 31;
 
-        let node = store.conventions.objectMapper.toObjectLiteral(user);
+        const node = store.conventions.objectMapper.toObjectLiteral(user);
 
         const command = new PutDocumentCommand("users/2", null, node);
         await store.getRequestExecutor().execute(command);

test/Ported/HiLoTest.ts

@@ -252,7 +252,7 @@ describe("HiLo", function () {
         const usersIds = new Map<number, boolean>();
         const productsIds = new Map<number, boolean>();
 
-        let count = 10;
+        const count = 10;
         const tasks: Promise<void>[] = [];
 
         for (let i = 0; i < count; i++) {