code cleanup

Author: gregolsky

src/Documents/Commands/Batches/BatchCommand.ts

@@ -105,21 +105,6 @@ export class BatchCommand extends RavenCommand<BatchCommandResult> implements ID
         }
 
         return request;
-        /* TBD: attachments - TODO: delete me?
-
-        if (_attachmentStreams != null && _attachmentStreams.Count > 0)
-        {
-            var multipartContent = new MultipartContent {request.Content};
-            foreach (var stream in _attachmentStreams)
-            {
-                PutAttachmentCommandHelper.PrepareStream(stream);
-                var streamContent = new AttachmentStreamContent(stream, CancellationToken);
-                streamContent.Headers.TryAddWithoutValidation("Command-Type", "AttachmentStream");
-                multipartContent.Add(streamContent);
-            }
-            request.Content = multipartContent;
-        }
-            */
     }
 
     public async setResponseAsync(bodyStream: stream.Stream, fromCache: boolean): Promise<string> {

src/Documents/Commands/MultiGet/GetRequest.ts

@@ -1,4 +1,3 @@
-//TODO: fill missing JSDocs?
 export class GetRequest {
     private _url: string;
     private _headers: { [key: string]: string | string[] };

src/Documents/Conventions/DocumentConventions.ts

@@ -45,7 +45,6 @@ export class DocumentConventions {
     private _frozen: boolean;
     private _originalConfiguration: ClientConfiguration;
     private _idPropertyCache: Map<ObjectTypeDescriptor, string> = new Map(); //TODO: is it used?
-    // TODO: private _saveEnumsAsIntegers: number;
     private _identityPartsSeparator: string;
     private _disableTopologyUpdates: boolean;
 
@@ -457,10 +456,6 @@ export class DocumentConventions {
         return this;
     }
 
-    //TODO public registerEntityTypeChecker(typeChecker: ObjectLiteralDescriptor) {
-    //     this._registeredTypeDescriptors.push(typeChecker);
-    // }
-
     public registerEntityIdPropertyName(ctorOrTypeChecker: ObjectTypeDescriptor, idProperty: string) {
         this._registeredIdPropertyNames.set(ctorOrTypeChecker, idProperty);
     }

src/Documents/Identity/IHiloIdGenerator.ts

@@ -1,7 +1,6 @@
 import { DocumentConventions } from "../Conventions/DocumentConventions";
 
 export interface IHiloIdGenerator {
-    //TODO ? nextId(...args: Array<object | string | string>): Promise<number>;
     generateDocumentId(...args: any[]): Promise<string>;
 
     returnUnusedRange(): Promise<void>;

src/Documents/Session/EntityToJson.ts

@@ -37,7 +37,6 @@ export class EntityToJson {
             typeInfo = _typeInfo;
         }, conventions.knownEntityTypesByName);
 
-        // TODO handle Maps
         if (entity instanceof SetupDocumentBase) {
             jsonNode = entity.toRemoteFieldNames();
         } else {

src/Documents/Session/Operations/Lazy/IndexQueryContent.ts

@@ -144,7 +144,6 @@ export class SubscriptionBatch<T extends object> {
 
             if (!item.exception) {
                 instance = curDoc;
-                //TODO: make sure above assignment is correct when entities has custom casing
 
                 if (!StringUtil.isNullOrEmpty(id)) {
                     this._generateEntityIdOnTheClient.trySetIdentity(instance, id);

src/Documents/Subscriptions/SubscriptionBatch.ts

@@ -33,7 +33,7 @@ export class ObjectKeyCaseTransformStream extends stream.Transform {
     constructor(private _opts: ObjectKeyCaseTransformStreamOptions) {
         super({ objectMode: true });
 
-        this._opts = Object.assign({}, DEFAULT_OBJECT_KEY_CASE_TRANSFORM_OPTS, this._opts); //TODO:
+        this._opts = Object.assign({}, DEFAULT_OBJECT_KEY_CASE_TRANSFORM_OPTS, this._opts);
         ObjectKeyCaseTransformStream._validateOpts(_opts);
 
         if (typeof _opts.extractIgnorePaths === "function") {

src/Mapping/Json/Streams/ObjectKeyCaseTransformStream.ts

@@ -21,16 +21,6 @@ export class GetClusterTopologyCommand extends RavenCommand<ClusterTopologyRespo
         return { uri };
     }
 
-    public setResponse(response: string, fromCache: boolean): void { //TODO: do we need this method?
-        if (!response) {
-            this._throwInvalidResponse();
-        }
-
-        const resObj = this._serializer.deserialize<IRavenResponse>(response);
-        const clusterTpl = Object.assign(new ClusterTopology(), resObj.topology);
-        this.result = Object.assign(resObj as ClusterTopologyResponse, { topology: clusterTpl });
-    }
-
     public async setResponseAsync(bodyStream: stream.Stream, fromCache: boolean): Promise<string> {
         if (!bodyStream) {
             this._throwInvalidResponse();

src/ServerWide/Commands/GetClusterTopologyCommand.ts

@@ -44,21 +44,6 @@ export class GetDatabaseNamesCommand extends RavenCommand<string[]> {
         return { uri };
     }
 
-    public setResponse(response: string, fromCache: boolean): void { //TODO: do we need this method?
-        if (!response) {
-            this._throwInvalidResponse();
-            return;
-        }
-
-        const { databases } =
-            this._serializer.deserialize<IRavenResponse>(response) as { databases: string[] };
-        if (!databases || !Array.isArray(databases) || !databases.length) {
-            this._throwInvalidResponse();
-        }
-
-        this.result = databases;
-    }
-
     public async setResponseAsync(bodyStream: stream.Stream, fromCache: boolean): Promise<string> {
         if (!bodyStream) {
             this._throwInvalidResponse();