add tests for stream-json coping with negative etags

Author: gregolsky

src/Http/RavenCommandResponsePipeline.ts

@@ -166,14 +166,7 @@ export class RavenCommandResponsePipeline<TStreamResult> extends EventEmitter {
 
         if (opts.jsonAsync) {
             const parser = new Parser({
-                packKeys: true,
-                packStrings: true,
-                packValues: true,
-                packNumbers: true,
-                streamNumbers: false,
-                streamValues: false,
-                streamKeys: false,
-                streamStrings: false
+                packKeys: true
             });
             streams.push(parser);
 

src/Mapping/Json/Streams/Pipelines.ts

@@ -27,13 +27,7 @@ export function getDocumentResultsPipeline(
     return RavenCommandResponsePipeline.create<object[]>()
         .parseJsonAsync([
             new TransformKeysJsonStream(getTransformJsonKeysProfile("DocumentLoad", conventions)),
-                // .on("data", x => console.log("TRANSF", x)),
-                // .on("end", () => console.log("TRANSF END")),
-            stringer({ 
-                useValues: true
-            })
-            // .on("data", x => console.log("STRINGER", x.toString()))
-            // .on("end", () => console.log("STRINGER END"))
+            stringer({ useValues: true })
         ]);
 }
 

test/Assets/queryResult.json

@@ -0,0 +1 @@
+{"ResultEtag":-7405531408361930253,"IsStale":false,"IndexName":"Users/ByName","TotalResults":10,"IndexTimestamp":"2018-10-08T07:02:43.9804130Z","Results":[{"name":"jon0","lastName":"snow0","@metadata":{"@collection":"Users","@nested-object-types":{},"Raven-Node-Type":"User","@change-vector":"A:2-Y7BIYp5+C024MXyo68JUfQ","@id":"users/1-A","@index-score":1,"@last-modified":"2018-10-08T07:02:43.9350760Z"}},{"name":"jon1","lastName":"snow1","@metadata":{"@collection":"Users","@nested-object-types":{},"Raven-Node-Type":"User","@change-vector":"A:3-Y7BIYp5+C024MXyo68JUfQ","@id":"users/2-A","@index-score":1,"@last-modified":"2018-10-08T07:02:43.9407694Z"}},{"name":"jon2","lastName":"snow2","@metadata":{"@collection":"Users","@nested-object-types":{},"Raven-Node-Type":"User","@change-vector":"A:4-Y7BIYp5+C024MXyo68JUfQ","@id":"users/3-A","@index-score":1,"@last-modified":"2018-10-08T07:02:43.9407980Z"}},{"name":"jon3","lastName":"snow3","@metadata":{"@collection":"Users","@nested-object-types":{},"Raven-Node-Type":"User","@change-vector":"A:5-Y7BIYp5+C024MXyo68JUfQ","@id":"users/4-A","@index-score":1,"@last-modified":"2018-10-08T07:02:43.9408069Z"}},{"name":"jon4","lastName":"snow4","@metadata":{"@collection":"Users","@nested-object-types":{},"Raven-Node-Type":"User","@change-vector":"A:6-Y7BIYp5+C024MXyo68JUfQ","@id":"users/5-A","@index-score":1,"@last-modified":"2018-10-08T07:02:43.9408172Z"}},{"name":"jon5","lastName":"snow5","@metadata":{"@collection":"Users","@nested-object-types":{},"Raven-Node-Type":"User","@change-vector":"A:7-Y7BIYp5+C024MXyo68JUfQ","@id":"users/6-A","@index-score":1,"@last-modified":"2018-10-08T07:02:43.9408252Z"}},{"name":"jon6","lastName":"snow6","@metadata":{"@collection":"Users","@nested-object-types":{},"Raven-Node-Type":"User","@change-vector":"A:8-Y7BIYp5+C024MXyo68JUfQ","@id":"users/7-A","@index-score":1,"@last-modified":"2018-10-08T07:02:43.9408326Z"}},{"name":"jon7","lastName":"snow7","@metadata":{"@collection":"Users","@nested-object-types":{},"Raven-Node-Type":"User","@change-vector":"A:9-Y7BIYp5+C024MXyo68JUfQ","@id":"users/8-A","@index-score":1,"@last-modified":"2018-10-08T07:02:43.9408404Z"}},{"name":"jon8","lastName":"snow8","@metadata":{"@collection":"Users","@nested-object-types":{},"Raven-Node-Type":"User","@change-vector":"A:10-Y7BIYp5+C024MXyo68JUfQ","@id":"users/9-A","@index-score":1,"@last-modified":"2018-10-08T07:02:43.9408478Z"}},{"name":"jon9","lastName":"snow9","@metadata":{"@collection":"Users","@nested-object-types":{},"Raven-Node-Type":"User","@change-vector":"A:11-Y7BIYp5+C024MXyo68JUfQ","@id":"users/10-A","@index-score":1,"@last-modified":"2018-10-08T07:02:43.9408566Z"}}]}

test/Mapping/StreamJsonTests.ts

@@ -0,0 +1,92 @@
+import * as fs from "fs";
+import * as path from "path";
+import * as stream from "readable-stream";
+import * as assert from "assert";
+import * as Parser from "stream-json/Parser";
+import { stringer } from "stream-json/Stringer";
+
+describe("stream-json parser and stringer", function () {
+
+    it("stringer using values can stringify negative numbers when parser packing keys", (done) => {
+
+        const content = `{"test":-1}`;
+        const readable = new stream.Readable();
+        readable.push(content);
+        readable.push(null);
+
+        const parser = new Parser({
+            packKeys: true
+        });
+
+        let hasNumberChunk = false;
+        parser.on("data", x => hasNumberChunk = hasNumberChunk || x.name === "numberChunk");
+
+        const stringerInstance = stringer({ useValues: true });
+        let output = "";
+        stringerInstance.on("data", data => output += data.toString());
+
+        stream.pipeline(
+            readable,
+            parser,
+            stringerInstance, 
+            (err) => {
+                err ? done(err) : done();
+                assert.strictEqual(output, content);
+            });
+    });
+
+    // TODO waiting for resolution of https://github.com/uhop/stream-json/issues/44
+    it.skip("parser with streamNumbers turned off should not emit 'numberChunk' tokens", (done) => {
+
+        const content = `{ "test": -1 }`;
+        const readable = new stream.Readable();
+        readable.push(content);
+        readable.push(null);
+
+        const parser = new Parser({
+            packKeys: true,
+            packStrings: true,
+            packValues: true,
+            packNumbers: true,
+            streamNumbers: false,
+            streamValues: false,
+            streamKeys: false,
+            streamStrings: false
+        });
+
+        let hasNumberChunk = false;
+        parser.on("data", x => hasNumberChunk = hasNumberChunk || x.name === "numberChunk");
+
+        stream.pipeline(
+            readable,
+            parser,
+            (err) => {
+                err ? done(err) : done();
+                assert.ok(!hasNumberChunk);
+            });
+    });
+
+    it("stringer for query result response with negative result etag", (done) => {
+        const content = fs.readFileSync(path.join(__dirname, "../Assets/queryResult.json"), "utf-8");
+        const readable = new stream.Readable();
+        readable.push(content);
+        readable.push(null);
+
+        const parser = new Parser({
+            packKeys: true
+        });
+
+        const stringerInstance = stringer({ useValues: true });
+        let output = "";
+        stringerInstance.on("data", data => output += data.toString());
+
+        stream.pipeline(
+            readable,
+            parser,
+            stringerInstance, 
+            (err) => {
+                err ? done(err) : done();
+                assert.strictEqual(output, content);
+            });
+    });
+});

test/Ported/Core/Streaming/QueryStreaming.ts

@@ -220,7 +220,7 @@ describe("query streaming", function () {
             session.advanced.streamInto(query, targetStream);
             await StreamUtil.finishedAsync(targetStream);
 
-            const result: string = targetStream["string"]; 
+            const result: string = targetStream["string"];
             assert.ok(result);
             const json = parseJsonVerbose(result);
             assert.ok(json);