Merge pull request #216 from gregolsky/RDBC-404

RDBC-404 fix GetDatabaseNamesCommand failing for an empty server

Author: gregolsky

src/ServerWide/Operations/GetDatabaseNamesOperation.ts

@@ -54,7 +54,7 @@ export class GetDatabaseNamesCommand extends RavenCommand<string[]> {
         const results = await this._defaultPipeline(_ => body = _)
             .process(bodyStream);
         const { databases } = results as any;
-        if (!databases || !Array.isArray(databases) || !databases.length) {
+        if (!databases || !Array.isArray(databases)) {
             this._throwInvalidResponse();
         }
 

test/Issues/RDBC_404.ts

@@ -0,0 +1,46 @@
+import * as assert from "assert";
+import { testContext, disposeTestDocumentStore } from "../Utils/TestUtil";
+
+import DocumentStore, {
+    IDocumentStore, GetDatabaseNamesOperation, DeleteDatabasesOperation,
+} from "../../src";
+import { delay } from "../../src/Utility/PromiseUtil";
+
+describe("RDBC-404", function () {
+
+    let store: IDocumentStore;
+
+    beforeEach(async function () {
+        testContext.customizeStore = async (store) => {
+
+            store.conventions.findCollectionNameForObjectLiteral = x => "test";
+        };
+        store = await testContext.getDocumentStore();
+    });
+
+    afterEach(async () => {
+        await disposeTestDocumentStore(store);
+    });
+
+    it("GetDatabaseNamesOperation does not fail for an empty server", async () => {
+
+        const store2 = new DocumentStore(store.urls, null);
+        try {
+            store2.initialize();
+            try {
+                store.dispose();
+            // tslint:disable-next-line: no-empty
+            } catch {}
+
+            const dbs = await store2.maintenance.server.send(new GetDatabaseNamesOperation(0, 10));
+            await store2.maintenance.server.send(new DeleteDatabasesOperation({
+                databaseNames: dbs,
+                hardDelete: true
+            }));
+
+            await store.maintenance.server.send(new GetDatabaseNamesOperation(0, 10));
+        } finally {
+            store2.dispose();
+        }
+    });
+});