Merge pull request #164 from gregolsky/v4.0

sync up with jvm f50f79080d050a47ccc84e76d9bd2ab0e2a42b71

Author: gregolsky

src/Constants.ts

@@ -28,6 +28,7 @@ export const CONSTANTS = {
             RAVEN_JS_TYPE: "Raven-Node-Type",
             CHANGE_VECTOR: "@change-vector",
             EXPIRES: "@expires",
+            ALL_DOCUMENTS_COLLECTION: "@all_docs",
             EMPTY_COLLECTION: "@empty",
             NESTED_OBJECT_TYPES: "@nested-object-types",
             IGNORE_CASE_TRANSFORM_REGEX:

src/Documents/BulkInsertOperation.ts

@@ -20,6 +20,7 @@ import { DocumentConventions } from "./Conventions/DocumentConventions";
 import { ServerNode } from "../Http/ServerNode";
 import { AbstractCallback } from "../Types/Callbacks";
 import { passResultToCallback } from "../Utility/PromiseUtil";
+import { BatchOperation } from "./Session/Operations/BatchOperation";
 
 export class BulkInsertOperation {
     private readonly _generateEntityIdOnTheClient: GenerateEntityIdOnTheClient;
@@ -191,7 +192,23 @@ export class BulkInsertOperation {
         }
 
         const jsonString = JsonSerializer.getDefault().serialize(json);
-        this._currentWriter.push(`{"Id":"${id}","Type":"PUT","Document":${jsonString}}`);
+        this._currentWriter.push(`{"Id":"${BulkInsertOperation._writeId(id)}","Type":"PUT","Document":${jsonString}}`);
+    }
+
+    private static _writeId(input: string): string {
+        let result = "";
+        for (let i = 0; i < input.length; i++) {
+            const c = input[i];
+            if (`"` === c) {
+                if (i === 0 || input[i - 1] !== `\\`) {
+                    result += `\\`;
+                }
+            }
+
+            result += c;
+        }
+
+        return result;
     }
 
     private async _checkIfBulkInsertWasAborted() {

src/Documents/Operations/Revisions/ConfigureRevisionsOperation.ts

@@ -17,17 +17,15 @@ export class ConfigureRevisionsOperation implements IMaintenanceOperation<Config
     }
 
     public getCommand(conventions: DocumentConventions): RavenCommand<ConfigureRevisionsOperationResult> {
-        return new ConfigureRevisionsCommand(conventions, this._configuration);
+        return new ConfigureRevisionsCommand(this._configuration);
     }
 }
 
 export class ConfigureRevisionsCommand extends RavenCommand<ConfigureRevisionsOperationResult> {
-    private readonly _conventions: DocumentConventions;
     private readonly _configuration: RevisionsConfiguration;
 
-    public constructor(conventions: DocumentConventions, configuration: RevisionsConfiguration) {
+    public constructor(configuration: RevisionsConfiguration) {
         super();
-        this._conventions = conventions;
         this._configuration = configuration;
     }
 

src/Documents/Session/DocumentSession.ts

@@ -400,7 +400,9 @@ export class DocumentSession extends InMemoryDocumentSessionOperations
         }
 
         const patchRequest = new PatchRequest();
-        patchRequest.script = "this." + path + " += args.val_" + this._valsCount + ";";
+        const variable = `this.${path}`;
+        const value = `args.val_${this._valsCount}`;
+        patchRequest.script = `${variable} = ${variable} ? ${variable} + ${value} : ${value};`;
         const valKey = "val_" + this._valsCount;
         patchRequest.values = { [valKey]: valueToAdd };
 
@@ -546,7 +548,8 @@ export class DocumentSession extends InMemoryDocumentSessionOperations
 
         if (!isIndex && !isCollection) {
             const entityType = this.conventions.findEntityType(opts.documentType);
-            collection = this.conventions.getCollectionNameForType(entityType);
+            collection = this.conventions.getCollectionNameForType(entityType) 
+                || CONSTANTS.Documents.Metadata.ALL_DOCUMENTS_COLLECTION;
         }
 
         return { indexName, collection };