From c879857740d6f183365030250657fa978a91ddc2 Mon Sep 17 00:00:00 2001 From: rameel Date: Tue, 3 Nov 2026 19:59:55 +0500 Subject: [PATCH] parsers: reset ThenIgnore output value on parse failure --- src/Ramstack.Parsing/Parser.ThenIgnore.cs | 2 + .../ParsersTests.FailureValue.cs | 55 +++++++++++++++++++ 2 files changed, 57 insertions(+) create mode 100644 tests/Ramstack.Parsing.Tests/ParsersTests.FailureValue.cs diff --git a/src/Ramstack.Parsing/Parser.ThenIgnore.cs b/src/Ramstack.Parsing/Parser.ThenIgnore.cs index 06aadb0..b0f6371 100644 --- a/src/Ramstack.Parsing/Parser.ThenIgnore.cs +++ b/src/Ramstack.Parsing/Parser.ThenIgnore.cs @@ -45,6 +45,8 @@ public override bool TryParse(ref ParseContext context, [NotNullWhen(true)] out } context.RestorePosition(bookmark); + value = default; + return false; } diff --git a/tests/Ramstack.Parsing.Tests/ParsersTests.FailureValue.cs b/tests/Ramstack.Parsing.Tests/ParsersTests.FailureValue.cs new file mode 100644 index 0000000..4473502 --- /dev/null +++ b/tests/Ramstack.Parsing.Tests/ParsersTests.FailureValue.cs @@ -0,0 +1,55 @@ +using static Ramstack.Parsing.Parser; + +namespace Ramstack.Parsing; + +partial class ParsersTests +{ + [TestCase("x")] + [TestCase("xb")] + [TestCase("xa")] + [TestCase("xac")] + public void ThenIgnore_FailedMatch_ResetsValue(string source) + { + AssertFailedValue(L('a').ThenIgnore(L('b')), source); + AssertFailedValue(L('a').Do(c => c.ToString()).ThenIgnore(L('b')), source); + AssertFailedValue(L('a').Do(c => (c, 42)).ThenIgnore(L('b')), source); + } + + [TestCase("named")] + [TestCase("where")] + [TestCase("deferred")] + public void TryParse_WrappedFailedMatch_ResetsValue(string wrapper) + { + var parser = L('a').ThenIgnore(L('b')); + switch (wrapper) + { + case "named": + parser = parser.As("token"); + break; + case "where": + parser = parser.Where(_ => true, "token"); + break; + case "deferred": + var deferred = Deferred(); + deferred.Parser = parser; + parser = deferred; + break; + } + + AssertFailedValue(parser, "xac"); + } + + private static void AssertFailedValue(Parser parser, string source) + { + var context = new ParseContext(source); + context.Advance(1); + + Assert.That(parser.TryParse(ref context, out var value), Is.False); + Assert.That(value, Is.EqualTo(default(T))); + Assert.That(context.Position, Is.EqualTo(1)); + Assert.That(context.MatchedSegment.Length, Is.Zero); + + Assert.That(parser.TryParse(source.AsSpan(1), out value), Is.False); + Assert.That(value, Is.EqualTo(default(T))); + } +}