Use the beam_transition on all relevant rules

Author: HoloRin

erlang_app_info.bzl

@@ -66,15 +66,15 @@ erlang_app_info = rule(
         "app": attr.label(allow_files = [".app"]),
         "beam": attr.label_list(
             allow_files = [".beam", ".appup"],
-            # cfg = beam_transition,
+            cfg = beam_transition,
         ),
         "priv": attr.label_list(allow_files = True),
         "license_files": attr.label_list(allow_files = True),
         "srcs": attr.label_list(allow_files = True),
         "deps": attr.label_list(providers = [ErlangAppInfo]),
-        # "_allowlist_function_transition": attr.label(
-        #     default = "@bazel_tools//tools/allowlists/function_transition_allowlist",
-        # ),
+        "_allowlist_function_transition": attr.label(
+            default = "@bazel_tools//tools/allowlists/function_transition_allowlist",
+        ),
     },
     provides = [ErlangAppInfo],
 )

private/erlang_bytecode.bzl

@@ -1,6 +1,7 @@
 load("//:erlang_app_info.bzl", "ErlangAppInfo")
 load("//:util.bzl", "path_join")
 load(":util.bzl", "erl_libs_contents")
+load("//transitions:beam_transition.bzl", "beam_transition")
 load(
     "//tools:erlang_toolchain.bzl",
     "erlang_dirs",
@@ -146,14 +147,11 @@ fi
 
 erlang_bytecode = rule(
     implementation = _impl,
+    cfg = beam_transition,
     attrs = {
         "compile_first": attr.label(
             executable = True,
-            # I would have thought this should be "exec", since this is run
-            # in the execution environment. However, it's an ecript needing
-            # beam, and "target" allows it to match the toolchains for this
-            # rule.
-            cfg = "target",
+            cfg = "exec",
         ),
         "app_name": attr.string(),
         "hdrs": attr.label_list(
@@ -165,6 +163,7 @@ erlang_bytecode = rule(
         ),
         "beam": attr.label_list(
             allow_files = [".beam"],
+            cfg = beam_transition,
         ),
         "deps": attr.label_list(
             providers = [ErlangAppInfo],
@@ -176,6 +175,9 @@ erlang_bytecode = rule(
         "dest": attr.string(
             default = "ebin",
         ),
+        "_allowlist_function_transition": attr.label(
+            default = "@bazel_tools//tools/allowlists/function_transition_allowlist",
+        ),
     },
     toolchains = ["//tools:toolchain_type"],
 )

private/erlang_bytecode2.bzl

@@ -135,7 +135,7 @@ erlang_bytecode = rule(
         ),
         "beam": attr.label_list(
             allow_files = [".beam"],
-            # cfg = beam_transition,
+            cfg = beam_transition,
         ),
         "deps": attr.label_list(
             providers = [ErlangAppInfo],

private/escript_archive.bzl

@@ -143,14 +143,14 @@ escript_archive = rule(
         "hdrs": attr.label_list(allow_files = [".hrl"]),
         "beam": attr.label_list(
             allow_files = [".beam"],
-            # cfg = beam_transition,
+            cfg = beam_transition,
         ),
         "app": attr.label(providers = [ErlangAppInfo]),
         "flat": attr.bool(),
         "drop_hrl": attr.bool(),
-        # "_allowlist_function_transition": attr.label(
-        #     default = "@bazel_tools//tools/allowlists/function_transition_allowlist",
-        # ),
+        "_allowlist_function_transition": attr.label(
+            default = "@bazel_tools//tools/allowlists/function_transition_allowlist",
+        ),
     },
     toolchains = ["//tools:toolchain_type"],
     executable = True,

private/eunit.bzl

@@ -178,7 +178,7 @@ eunit_test = rule(
         "is_windows": attr.bool(mandatory = True),
         "compiled_suites": attr.label_list(
             allow_files = [".beam"],
-            # cfg = beam_transition,
+            cfg = beam_transition,
         ),
         "eunit_mods": attr.string_list(),
         "target": attr.label(providers = [ErlangAppInfo]),
@@ -191,9 +191,9 @@ eunit_test = rule(
         ),
         "tools": attr.label_list(),
         "test_env": attr.string_dict(),
-        # "_allowlist_function_transition": attr.label(
-        #     default = "@bazel_tools//tools/allowlists/function_transition_allowlist",
-        # ),
+        "_allowlist_function_transition": attr.label(
+            default = "@bazel_tools//tools/allowlists/function_transition_allowlist",
+        ),
     },
     toolchains = ["//tools:toolchain_type"],
     test = True,